Granite

Merge lp://staging/~marcus-lundgren/granite/fix-872099 into lp://staging/~elementary-pantheon/granite/granite

  1. fix-872099
  2. Merge into granite
Proposed by Marcus Lundgren
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://staging/~marcus-lundgren/granite/fix-872099
Merge into: lp://staging/~elementary-pantheon/granite/granite
Diff against target: 12 lines (+1/-1)
1 file modified
lib/Widgets/DatePicker.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~marcus-lundgren/granite/fix-872099
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Review via email: mp+111111@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Changing a date you already picked has strange results.

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

Cody, is this an issue that was introduced here or was it already present in trunk? If it was already present in trunk, this shouldn't be a blocker to merging this branch, but rather a separate issue.

Revision history for this message
Marcus Lundgren (marcus-lundgren) wrote :

Daniel: The branch introduced several new bugs, so the code as it is should not be merged into trunk.

Unmerged revisions

276. By Marcus Lundgren

Date is now picked with a single instead of a double click.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches