Merge lp://staging/~marcoceppi/charm-tools/better-getall into lp://staging/charm-tools/1.6
Proposed by
Marco Ceppi
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~marcoceppi/charm-tools/better-getall | ||||
| Merge into: | lp://staging/charm-tools/1.6 | ||||
| Diff against target: |
94 lines (+18/-6) 4 files modified
charmtools/get.py (+2/-2) charmtools/getall.py (+2/-0) charmtools/search.py (+11/-1) tests/test_charm_get.py (+3/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~marcoceppi/charm-tools/better-getall | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charm Toolers | Pending | ||
|
Review via email:
|
|||
Description of the change
Have search use the API
To post a comment you must log in.
Revision history for this message
| Adam Israel (aisrael) wrote | # |
Unmerged revisions
- 354. By Marco Ceppi
-
Search against the API
- 353. By Marco Ceppi
-
Make Charm imports simpler
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey Marco,
Some brief comments on this merge. I did a quick run through, testing getall. It look like it's working fine here. I particularly like the flag to fetch by series.
I have run into an intermittent "Connection Timeout: disconnecting client after 300.0 seconds" with the previous revision and this one, and I wonder if that could also be fixed here. It's confusing when that warning pops up. I don't know if it's skipped a charm due to timeout, or if it retried. I've also had it happen at the end of a getall, which at first left me thinking that the timeout aborted the fetch (which is not the case, afaict).