leo-editor

Merge lp://staging/~maphew/leo-editor/doc-edits into lp://staging/leo-editor

  1. doc-edits
  2. Merge into trunk3
Proposed by Matt Wilkie
Status: Needs review
Proposed branch: lp://staging/~maphew/leo-editor/doc-edits
Merge into: lp://staging/leo-editor
Diff against target: 76 lines (+16/-6)
1 file modified
leo/doc/LeoDocs.leo (+16/-6)
To merge this branch: bzr merge lp://staging/~maphew/leo-editor/doc-edits
Reviewer Review Type Date Requested Status
The Leo editor team Pending
Review via email: mp+191938@code.staging.launchpad.net

Commit message

a few minor edits to LeoDocs.leo >> Preliminaries

Description of the change

a few minor edits to LeoDocs.leo >> Preliminaries.

They are suggestions, feel free to pick and choose the ones you like.

To post a comment you must log in.
lp://staging/~maphew/leo-editor/doc-edits updated
6172. By Matt Wilkie

add best guess for date of Joe's endorsement. (On general principle I think all of the long quotes should be dated, and, where possible linked to the first post)

6173. By Matt Wilkie

one typo, and fix formatting on a numbered list

Revision history for this message
Edward K. Ream (edreamleo) wrote :

On Mon, Oct 21, 2013 at 12:15 AM, Matt Wilkie <email address hidden> wrote:

> Matt Wilkie has proposed merging lp:~maphew/leo-editor/doc-edits into
> lp:leo-editor.
>

​Thanks for the edits. I'll review them and merge by hand into LeoDocs.leo.

Edward

Reply
Revision history for this message
Matt Wilkie (maphew) wrote :

you're welcome. :)

Since it appears hand merging is a preferred workflow to using launchpad,
is there are also a better way to give you corrections?

I used bzr because of the simpleness of using the commit message to share
the reasoning behind each of the changes.

On Mon, Oct 21, 2013 at 9:36 AM, Edward K. Ream <email address hidden> wrote:

> On Mon, Oct 21, 2013 at 12:15 AM, Matt Wilkie <email address hidden> wrote:
>
> > Matt Wilkie has proposed merging lp:~maphew/leo-editor/doc-edits into
> > lp:leo-editor.
> >
>
> Thanks for the edits. I'll review them and merge by hand into LeoDocs.leo.
>
> Edward
>
> --
> https://code.launchpad.net/~maphew/leo-editor/doc-edits/+merge/191938
> You are the owner of lp:~maphew/leo-editor/doc-edits.
>

Reply
Revision history for this message
Edward K. Ream (edreamleo) wrote :

On Mon, Oct 21, 2013 at 4:30 PM, Matt Wilkie <email address hidden> wrote:

> you're welcome. :)
>
> Since it appears hand merging is a preferred workflow to using launchpad,
> ​ ​
> is there are also a better way to give you corrections?
>
> I used bzr because of the simpleness of using the commit message to share
> ​ ​
> the reasoning behind each of the changes.
>

​The bzr diffs suffice, I think. But you could simply describe the
corrections if that is easier for you.

Edward

Reply
Revision history for this message
Edward K. Ream (edreamleo) wrote :

On Mon, Oct 21, 2013 at 12:15 AM, Matt Wilkie <email address hidden> wrote:

a few minor edits to LeoDocs.leo >> Preliminaries.
>
> They are suggestions, feel free to pick and choose the ones you like.
>

​Done. Thanks for your help.

Edward

Reply

Unmerged revisions

6173. By Matt Wilkie

one typo, and fix formatting on a numbered list

6172. By Matt Wilkie

add best guess for date of Joe's endorsement. (On general principle I think all of the long quotes should be dated, and, where possible linked to the first post)

6171. By Matt Wilkie

Joe Orr's website is gone, perhaps the Web Archive?

6170. By Matt Wilkie

Corrected date and linked to the public posting for Speed's mini Leo review

6169. By Matt Wilkie

unattributed quote now attributed to anonymous

6168. By Matt Wilkie

'traditional editors' instead of 'any other'; sounds less arrogant, and admits possib.of another editor which could do this, possibly (we just don't know about it).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches