Merge lp://staging/~manjo/ubuntu/trusty/debian-installer/HP-m800 into lp://staging/~ubuntu-core-dev/debian-installer/trusty-proposed

Proposed by Manoj Iyer
Status: Rejected
Rejected by: Adam Conrad
Proposed branch: lp://staging/~manjo/ubuntu/trusty/debian-installer/HP-m800
Merge into: lp://staging/~ubuntu-core-dev/debian-installer/trusty-proposed
Diff against target: 106 lines (+74/-1)
5 files modified
build/boot/arm/keystone.preseed (+40/-0)
build/config/armel/keystone.cfg (+13/-0)
build/config/armel/keystone/netboot.cfg (+14/-0)
build/config/armhf.cfg (+1/-1)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://staging/~manjo/ubuntu/trusty/debian-installer/HP-m800
Reviewer Review Type Date Requested Status
dann frazier Needs Fixing
Adam Conrad Pending
Ubuntu Core Development Team Pending
Review via email: mp+225428@code.staging.launchpad.net

Description of the change

Build netboot installer for armhf TI/keystone

To post a comment you must log in.
Revision history for this message
dann frazier (dannf) wrote :

Please drop the preseed.

review: Needs Fixing
Revision history for this message
Manoj Iyer (manjo) wrote :

> Please drop the preseed.

I have pushed another branch without the preseed. The reason I added the preseed is to disable irqbalance at install, but to Dann's point the user could preseed this out as well. irqbalance was disabled in HP m800 to address some of the network performance problems, from out testing we found that throughput could reach line rate with irqbalance disabled, and severely dropped if irqbalance was enabled. irqbalance disturbs the optimized network IRQ policy on keystone II systems.

MP of V2 with preseed removed can be found here:
https://code.launchpad.net/~manjo/ubuntu/trusty/debian-installer/HP-m800v2/+merge/225556

Revision history for this message
Manoj Iyer (manjo) wrote :

> > Please drop the preseed.
>
> I have pushed another branch without the preseed. The reason I added the
> preseed is to disable irqbalance at install, but to Dann's point the user
> could preseed this out as well. irqbalance was disabled in HP m800 to address
> some of the network performance problems, from out testing we found that
> throughput could reach line rate with irqbalance disabled, and severely
> dropped if irqbalance was enabled. irqbalance disturbs the optimized network
> IRQ policy on keystone II systems.
>
> MP of V2 with preseed removed can be found here:
> https://code.launchpad.net/~manjo/ubuntu/trusty/debian-installer/HP-
> m800v2/+merge/225556

side note: We could consider disabling irqbalance on all armhf, it is an intel thing anyway.

Revision history for this message
Adam Conrad (adconrad) wrote :

Taking the version without the preseed.

Unmerged revisions

1979. By Manoj Iyer

Build netboot installer for armhf TI keystone - keystone specific changes

1978. By Manoj Iyer

Build netboot installer for armhf TI keystone

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches