Merge lp://staging/~manishsinha/zeitgeist-sharp/architecture-issues into lp://staging/~zeitgeist-sharp/zeitgeist-sharp/trunk
Proposed by
Manish Sinha (मनीष सिन्हा)
| Status: | Rejected |
|---|---|
| Rejected by: | Manish Sinha (मनीष सिन्हा) |
| Proposed branch: | lp://staging/~manishsinha/zeitgeist-sharp/architecture-issues |
| Merge into: | lp://staging/~zeitgeist-sharp/zeitgeist-sharp/trunk |
| Diff against target: |
341 lines (+73/-110) 11 files modified
Zeitgeist.Testsuite/Blacklist/TestMonitor.cs (+4/-2) Zeitgeist.Testsuite/Log/TestDeleteEvents.cs (+0/-50) Zeitgeist.Testsuite/Log/TestFindEventIds.cs (+2/-2) Zeitgeist.Testsuite/Log/TestFindEvents.cs (+2/-2) Zeitgeist.Testsuite/Log/TestInsertAndDeleteEvents.cs (+50/-0) Zeitgeist.Testsuite/Log/TestInsertEvents.cs (+0/-38) Zeitgeist.Testsuite/Zeitgeist.Testsuite.csproj (+1/-2) Zeitgeist/Datamodel/DataSource.cs (+2/-2) Zeitgeist/Datamodel/Event.cs (+2/-2) Zeitgeist/Datamodel/Monitor.cs (+2/-2) Zeitgeist/LogClient.cs (+8/-8) |
| To merge this branch: | bzr merge lp://staging/~manishsinha/zeitgeist-sharp/architecture-issues |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zeitgeist Sharp | Pending | ||
|
Review via email:
|
|||
Description of the change
Made changes to the type
changed int to Int32, uint to UInt32 , long to Int64 and ulong to UInt64
To post a comment you must log in.
Unmerged revisions
- 50. By Manish Sinha (मनीष सिन्हा)
-
Fixed bug #665051
- 49. By Manish Sinha (मनीष सिन्हा)
-
Changes all instances of long to Int64 and ulong to UInt64
- 48. By Manish Sinha (मनीष सिन्हा)
-
Fixed the long to Int64 in LogClient line 178,179
- 47. By Manish Sinha (मनीष सिन्हा)
-
Changes long to Int64 and uint to Int32
This is to make sure that the types match exactly as per the DBus method types. Otherwise using uint makes it 32bit on x86 and 64-bit on x86_64
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
