Merge lp://staging/~manishsinha/totem/enable-zg-dp-building into lp://staging/~ubuntu-desktop/totem/ubuntu

Status: Merged
Merged at revision: 121
Proposed branch: lp://staging/~manishsinha/totem/enable-zg-dp-building
Merge into: lp://staging/~ubuntu-desktop/totem/ubuntu
Diff against target: 82 lines (+17/-3)
5 files modified
debian/changelog (+6/-0)
debian/control (+4/-1)
debian/control.in (+4/-1)
debian/rules (+1/-1)
debian/totem-plugins.install (+2/-0)
To merge this branch: bzr merge lp://staging/~manishsinha/totem/enable-zg-dp-building
Reviewer Review Type Date Requested Status
Jeremy Bícha Approve
Review via email: mp+80492@code.staging.launchpad.net

Commit message

* debian/rules: Enabled vala support
* debian/control: Added valac, libzeitgeist-dev as build-dep and libzeitgeist-1.0-1 as dependency of totem-plugins
* debian/totem-plugins.intall: Added another entry for zeitgeist-dp

Description of the change

Enabled Zeitgeist datasource

Changed made
* Enabled the vala support in debian/rules
* Added an entry in totem-plugins.install
* Updated the respective dependencies in debian/control

To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Please make the same changes to debian/control.in that you do to debian/control.

The plugin appears to work for me. I activated it, played a video, and the video showed up in GNOME Activity Journal. I do get this error on activation but it didn't seem to be too serious.

GLib-GObject-CRITICAL **: Property 'object' on class 'ZeitgeistDpPlugin' has type 'TotemObject' which is different from the type 'GObject', of the property on interface 'PeasActivatable'

122. By Manish Sinha (मनीष सिन्हा)

Made the necessary changes to debian/control.in too

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I don't think that is much to be worried about. I keep on getting such messages even when running gaj from command line (though not the same)

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches