Merge lp://staging/~manishsinha/filestore/fix-sphinx-hardcoding-in-usrbin into lp://staging/filestore

Status: Merged
Merged at revision: 189
Proposed branch: lp://staging/~manishsinha/filestore/fix-sphinx-hardcoding-in-usrbin
Merge into: lp://staging/filestore
Diff against target: 32 lines (+11/-2)
1 file modified
setup.py (+11/-2)
To merge this branch: bzr merge lp://staging/~manishsinha/filestore/fix-sphinx-hardcoding-in-usrbin
Reviewer Review Type Date Requested Status
Jason Gerard DeRose Approve
Review via email: mp+74921@code.staging.launchpad.net

Description of the change

Fixed bugs #847044 where sphinx-build was hardcoded at /usr/bin/sphinx-build

Read the $PATH environment variable. Split it by : character. For every entry append
'sphinx-build' and check whether the file exists. If the file exists, check if it
is executable. If yes, then return the path. If none is found then return None.
The method calling this search method has to handle None return by showing a WARNING

To post a comment you must log in.
190. By Manish Sinha (मनीष सिन्हा)

Fix the stupid mistake where I changed sphinx-build to fallocate

191. By Manish Sinha (मनीष सिन्हा)

Replace os.path.isfile to path.isfile

192. By Manish Sinha (मनीष सिन्हा)

Fixed the name clash. Renamed variable path to file_path

Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Rock on, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches