Ubuntu One Client

Merge lp://staging/~mandel/ubuntuone-client/fix-803622 into lp://staging/ubuntuone-client

fix-803622
Merge into trunk

Proposed by Manuel de la Peña on 2011-06-30

Status:

Merged

Approved by:

Natalia Bidart on 2011-06-30

Approved revision:

1036

Merged at revision:

1034

Proposed branch:

lp://staging/~mandel/ubuntuone-client/fix-803622

Merge into:

lp://staging/ubuntuone-client

Diff against target:

64 lines (+29/-2)

2 files modified

tests/syncdaemon/test_action_queue.py (+28/-1)
ubuntuone/syncdaemon/action_queue.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~mandel/ubuntuone-client/fix-803622

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Natalia Bidart (community)	2011-06-30	Approve on 2011-06-30
Guillermo Gonzalez		Approve on 2011-06-30
Review via email: mp+66425@code.staging.launchpad.net

Commit message

Ensure that we use the correct mode when opening files: r+w is an illegal mode everywhere, and has been changed to w+b to ensure that it works on all platforms (LP: #803622).

Description of the change

Ensure that we use the correct mode. r+w is an illegal mode verywhere and has been changed to w+b to ensure that it will work on all platforms.

In order to run the tests on windows please do:

python C:\Python27\Scripts\u1trial tests\syncdaemon\test_action_queue.py -t test_fdopen

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2011-06-30:

Test needed! :-)

review: Needs Fixing

lp://staging/~mandel/ubuntuone-client/fix-803622 updated on 2011-06-30

1033. By Manuel de la Peña on 2011-06-30: Added test to ensure we use the correct mode.
1034. By Manuel de la Peña on 2011-06-30: Merged with changes form linux.
1035. By Manuel de la Peña on 2011-06-30: Added real test to ensure that we can read and write.