Merge lp://staging/~mandel/ubuntu-sso-client/send-signals into lp://staging/ubuntu-sso-client
Proposed by
Mike McCracken
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Roberto Alsina | ||||||||
| Approved revision: | 999 | ||||||||
| Merged at revision: | 997 | ||||||||
| Proposed branch: | lp://staging/~mandel/ubuntu-sso-client/send-signals | ||||||||
| Merge into: | lp://staging/ubuntu-sso-client | ||||||||
| Diff against target: |
14 lines (+3/-1) 1 file modified
ubuntu_sso/utils/runner/__init__.py (+3/-1) |
||||||||
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-sso-client/send-signals | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Use twisted process runner on darwin so we get process-finished notifications. (LP: #1043754)
Description of the change
- Use twisted process runner on darwin so we get process-finished notifications. (LP: #1043754)
Using the Qt runner on darwin doesn't correctly send the notification when the backend completes.
This causes a client app such as u1-control-panel to be frozen waiting for SSO. See e.g. bug #1037322.
NOTE: Since this is a workaround, the original Qt issue has been filed as bug #1049283 .
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
