Merge lp://staging/~mandel/ubuntu-sso-client/pinned-certs into lp://staging/ubuntu-sso-client
Proposed by
Manuel de la Peña
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Manuel de la Peña | ||||
| Proposed branch: | lp://staging/~mandel/ubuntu-sso-client/pinned-certs | ||||
| Merge into: | lp://staging/ubuntu-sso-client | ||||
| Prerequisite: | lp://staging/~mandel/ubuntu-sso-client/libsoup-ssl-dialog | ||||
| Diff against target: |
480 lines (+304/-51) 6 files modified
ubuntu_sso/utils/webclient/common.py (+23/-10) ubuntu_sso/utils/webclient/libsoup.py (+3/-13) ubuntu_sso/utils/webclient/qtnetwork.py (+2/-22) ubuntu_sso/utils/webclient/ssl_certs.py (+105/-0) ubuntu_sso/utils/webclient/tests/test_ssl_certs.py (+151/-0) ubuntu_sso/utils/webclient/tests/test_webclient.py (+20/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-sso-client/pinned-certs | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Manuel de la Peña (community) | Disapprove | ||
| dobey (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Added a ssl cert vault that will allow to remember pinned ssl certificates (LP: #955339)
Description of the change
- Added a ssl cert vault that will allow to remember pinned ssl certificates (LP: #955339)
To post a comment you must log in.
Unmerged revisions
- 952. By Manuel de la Peña
-
Remove unused function.
- 951. By Manuel de la Peña
-
Merged libsoup-ssl-dialog into pinned-certs.
- 950. By Manuel de la Peña
-
Merged libsoup-ssl-dialog into pinned-certs.
- 949. By Manuel de la Peña
-
Added the required code to store the pinned certificates in order to not promp the ssl dialog constantly.
- 948. By Manuel de la Peña
-
Pass the cert pem from the child WebClient implementations to the base class.
- 947. By Manuel de la Peña
-
Reduced diff size.
- 946. By Manuel de la Peña
-
Reduced diff size.
- 945. By Manuel de la Peña
-
Merged with trunk.
- 944. By Manuel de la Peña
-
Added the required code to let the libsoup webclient implementation deal with ssl cert errors.
- 943. By Manuel de la Peña
-
Made changes to the tests so that they work correctly.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me, but testing this IRL is a pain.