Merge lp://staging/~mandel/ubuntu-sso-client/fix-oneric-tests into lp://staging/ubuntu-sso-client
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~mandel/ubuntu-sso-client/fix-oneric-tests |
Merge into: | lp://staging/ubuntu-sso-client |
Diff against target: |
140 lines (+24/-34) 3 files modified
ubuntu_sso/utils/webclient/qtnetwork.py (+23/-12) ubuntu_sso/utils/webclient/tests/test_timestamp.py (+1/-1) ubuntu_sso/utils/webclient/tests/test_webclient.py (+0/-21) |
To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-sso-client/fix-oneric-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu One hackers | Pending | ||
Review via email:
|
Commit message
- Use a QNetworkAccessM
Description of the change
- Use a QNetworkAccessM
The main problem is that the signal is not fired, therefore we now have a collections of nams (kept in case we call shutdown in the middle). When the finish signal is fired we pass the nam (to call deleteLater) and the reply which contains the info from the request.
You will notice that some tests have been removed the reason is that they are not correct and the feature they were testing has been removed.
Also please take the following into account:
<alecu> mandel, also: make some wall clock tests to see that the time it takes the control panel to open and get all the info is not severely affected by using multiple nams
<alecu> mandel, and another thing that could break: the proxy password dialog may open too many times in this case...
<alecu> mandel, (multiple nams means that control panel api calls cannot reuse a single http connection)
<alecu> mandel, other than that, the code looks good, and it's a very good idea to try this as it will likely fix the issue with cached proxy credentials.
Unmerged revisions
- 956. By Manuel de la Peña
-
Remove left over print.
- 955. By Manuel de la Peña
-
Link bug.
- 954. By Manuel de la Peña
-
Clean the resources better in case we want to shutdown when there is a nam is used. Remove ssl tests that do not longer make sense.
- 953. By Manuel de la Peña
-
Fix timeout issues ensuring that we will use a new nam per request.