Merge lp://staging/~mandel/ubuntu-download-manager/vivid-add-appid-metadata into lp://staging/ubuntu-download-manager/vivid
Proposed by
Manuel de la Peña
| Status: | Merged |
|---|---|
| Approved by: | Manuel de la Peña |
| Approved revision: | 347 |
| Merged at revision: | 339 |
| Proposed branch: | lp://staging/~mandel/ubuntu-download-manager/vivid-add-appid-metadata |
| Merge into: | lp://staging/ubuntu-download-manager/vivid |
| Diff against target: |
3238 lines (+1069/-303) 72 files modified
CMakeLists.txt (+2/-2) debian/changelog (+19/-0) debian/control (+24/-24) debian/libubuntu-download-manager-client1.install (+1/-1) debian/libubuntu-download-manager-client1.symbols (+18/-1) debian/libubuntu-download-manager-common1.install (+1/-1) debian/libubuntu-download-manager-common1.symbols (+1/-1) debian/libubuntu-upload-manager-common1.install (+1/-1) debian/libubuntu-upload-manager-common1.symbols (+1/-1) debian/libudm-common-dev.install (+1/-0) debian/libudm-common1.install (+1/-1) debian/libudm-common1.symbols (+33/-17) debian/libudm-priv-common1.install (+1/-1) docs/dbus/com.canonical.applications.download.xml (+7/-0) docs/dbus/com.canonical.applications.testing.download_manager.xml (+7/-0) src/common/public/CMakeLists.txt (+2/-0) src/common/public/ubuntu/transfers/errors/auth_error_struct.cpp (+6/-5) src/common/public/ubuntu/transfers/errors/auth_error_struct.h (+9/-12) src/common/public/ubuntu/transfers/errors/hash_error_struct.cpp (+96/-0) src/common/public/ubuntu/transfers/errors/hash_error_struct.h (+122/-0) src/common/public/ubuntu/transfers/errors/http_error_struct.cpp (+2/-2) src/common/public/ubuntu/transfers/errors/http_error_struct.h (+3/-5) src/common/public/ubuntu/transfers/errors/network_error_struct.cpp (+2/-2) src/common/public/ubuntu/transfers/errors/network_error_struct.h (+3/-6) src/common/public/ubuntu/transfers/errors/process_error_struct.cpp (+7/-7) src/common/public/ubuntu/transfers/errors/process_error_struct.h (+8/-11) src/common/public/ubuntu/transfers/metadata.cpp (+33/-0) src/common/public/ubuntu/transfers/metadata.h (+6/-4) src/downloads/client/symbols.map (+6/-0) src/downloads/client/ubuntu/download_manager/download.h (+18/-4) src/downloads/client/ubuntu/download_manager/download_impl.cpp (+19/-1) src/downloads/client/ubuntu/download_manager/download_impl.h (+4/-4) src/downloads/client/ubuntu/download_manager/download_interface.cpp (+1/-1) src/downloads/client/ubuntu/download_manager/download_interface.h (+23/-18) src/downloads/client/ubuntu/download_manager/error.cpp (+88/-22) src/downloads/client/ubuntu/download_manager/error.h (+71/-6) src/downloads/client/ubuntu/download_manager/manager_impl.cpp (+3/-1) src/downloads/common/ubuntu/download_manager/metatypes.h (+4/-4) src/downloads/priv/ubuntu/downloads/download.h (+14/-3) src/downloads/priv/ubuntu/downloads/download_adaptor.cpp (+7/-1) src/downloads/priv/ubuntu/downloads/download_adaptor.h (+12/-3) src/downloads/priv/ubuntu/downloads/file_download.cpp (+2/-1) src/downloads/priv/ubuntu/downloads/file_download.h (+2/-1) src/downloads/priv/ubuntu/downloads/manager.cpp (+20/-0) src/downloads/priv/ubuntu/downloads/manager.h (+2/-4) src/downloads/test-daemon/testing_daemon.cpp (+12/-1) src/downloads/test-daemon/testing_daemon.h (+3/-4) src/downloads/test-daemon/testing_file_download.cpp (+17/-1) src/downloads/test-daemon/testing_file_download.h (+5/-4) src/downloads/test-daemon/testing_interface.cpp (+1/-1) src/downloads/test-daemon/testing_interface.h (+8/-1) src/downloads/test-daemon/testing_manager.cpp (+12/-3) src/downloads/test-daemon/testing_manager.h (+3/-4) src/downloads/test-daemon/testing_manager_adaptor.cpp (+9/-1) src/downloads/test-daemon/testing_manager_adaptor.h (+7/-1) src/downloads/test-daemon/ubuntu-download-manager-test-daemon.pro.THIS (+0/-44) tests/common/daemon_testcase.cpp (+26/-3) tests/common/daemon_testcase.h (+3/-4) tests/common/testing_interface.cpp (+1/-1) tests/common/testing_interface.h (+8/-1) tests/downloads/client/CMakeLists.txt (+7/-6) tests/downloads/client/test_client_download.cpp (+37/-1) tests/downloads/client/test_client_download.h (+4/-4) tests/downloads/client/test_client_manager.cpp (+1/-1) tests/downloads/client/test_group_manager_watch.h (+3/-5) tests/downloads/daemon/CMakeLists.txt (+2/-1) tests/downloads/daemon/test_download.cpp (+3/-1) tests/downloads/daemon/test_download_manager.cpp (+54/-0) tests/downloads/daemon/test_final_state.cpp (+0/-4) tests/downloads/daemon/test_metadata.cpp (+90/-0) tests/downloads/daemon/test_metadata.h (+10/-3) tests/downloads/qml/CMakeLists.txt (+30/-24) |
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-download-manager/vivid-add-appid-metadata |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alfonso Sanchez-Beato (community) | Approve | ||
|
Review via email:
|
|||
Commit message
The download object now carries the app id of the application that created the download.
Description of the change
The download object now carries the app id of the application that created the download. The client lib has been updated so that the applications do not need to set the app id. Unconfined apps will use the value in APP_ID, confined apps will use their apparmor profile.
To post a comment you must log in.
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) | # |
review:
Approve
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I did not find a way to get the download file name? Show we have a property for that on download interface? Or I am missing something?