Merge lp://staging/~mandel/ubuntu-download-manager/solve-leaks into lp://staging/ubuntu-download-manager
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Manuel de la Peña | ||||||||||||
| Approved revision: | 229 | ||||||||||||
| Merged at revision: | 207 | ||||||||||||
| Proposed branch: | lp://staging/~mandel/ubuntu-download-manager/solve-leaks | ||||||||||||
| Merge into: | lp://staging/ubuntu-download-manager | ||||||||||||
| Diff against target: |
2097 lines (+416/-361) 28 files modified
libubuntudownloadmanager/downloads/factory.cpp (+9/-0) libubuntudownloadmanager/downloads/factory.h (+2/-0) libubuntudownloadmanager/downloads/file_download.cpp (+0/-2) libubuntudownloadmanager/downloads/group_download.cpp (+0/-2) libubuntudownloadmanager/downloads/manager.cpp (+2/-2) libubuntudownloadmanager/downloads/manager.h (+0/-1) libubuntudownloadmanager/system/system_network_info.cpp (+4/-1) ubuntu-download-manager-tests/downloads/test_daemon.cpp (+12/-0) ubuntu-download-manager-tests/downloads/test_daemon.h (+2/-0) ubuntu-download-manager-tests/downloads/test_download.cpp (+156/-157) ubuntu-download-manager-tests/downloads/test_download_factory.cpp (+34/-27) ubuntu-download-manager-tests/downloads/test_download_manager.cpp (+61/-40) ubuntu-download-manager-tests/downloads/test_download_queue.cpp (+6/-3) ubuntu-download-manager-tests/downloads/test_download_queue.h (+0/-1) ubuntu-download-manager-tests/downloads/test_downloads_db.cpp (+13/-15) ubuntu-download-manager-tests/downloads/test_group_download.cpp (+85/-79) ubuntu-download-manager-tests/downloads/test_group_download.h (+0/-1) ubuntu-download-manager-tests/fakes/fake_apparmor.cpp (+7/-7) ubuntu-download-manager-tests/fakes/fake_application.cpp (+1/-1) ubuntu-download-manager-tests/fakes/fake_download.cpp (+1/-1) ubuntu-download-manager-tests/fakes/fake_download_factory.cpp (+5/-5) ubuntu-download-manager-tests/fakes/fake_file_manager.cpp (+1/-1) ubuntu-download-manager-tests/fakes/fake_network_reply.cpp (+4/-4) ubuntu-download-manager-tests/fakes/fake_process.cpp (+3/-3) ubuntu-download-manager-tests/fakes/fake_process_factory.cpp (+1/-1) ubuntu-download-manager-tests/fakes/fake_request_factory.cpp (+2/-2) ubuntu-download-manager-tests/fakes/fake_sm_file_download.cpp (+3/-3) ubuntu-download-manager-tests/fakes/fake_timer.cpp (+2/-2) |
||||||||||||
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-download-manager/solve-leaks | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Solve all known mem leaks from the project.
Description of the change
This branch solves all the known memory leaks in the project. in order to run the tests with valgrind do the following:
cd solve-leaks
mkdir build
cd build
qmake ../download-
make
LD_LIBRARY_
The above will run the tests and will check for mem leaks, in the result should be that the tests pass and that you have a result similar to the following:
==16989==
==16989== HEAP SUMMARY:
==16989== in use at exit: 34,884 bytes in 646 blocks
==16989== total heap usage: 520,198 allocs, 519,552 frees, 84,422,831 bytes allocated
==16989==
==16989== LEAK SUMMARY:
==16989== definitely lost: 0 bytes in 0 blocks
==16989== indirectly lost: 0 bytes in 0 blocks
==16989== possibly lost: 0 bytes in 0 blocks
==16989== still reachable: 34,884 bytes in 646 blocks
==16989== suppressed: 0 bytes in 0 blocks
==16989== Reachable blocks (those to which a pointer was found) are not shown.
==16989== To see them, rerun with: --leak-check=full --show-
==16989==
==16989== For counts of detected and suppressed errors, rerun with: -v
==16989== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
| PS Jenkins bot (ps-jenkins) wrote | # |
PASSED: Continuous integration, rev:229
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://