Merge lp://staging/~mandel/ubuntu-download-manager/singletons into lp://staging/ubuntu-download-manager
Proposed by
Manuel de la Peña
| Status: | Merged |
|---|---|
| Approved by: | Manuel de la Peña |
| Approved revision: | 221 |
| Merged at revision: | 206 |
| Proposed branch: | lp://staging/~mandel/ubuntu-download-manager/singletons |
| Merge into: | lp://staging/ubuntu-download-manager |
| Diff against target: |
2233 lines (+373/-392) 37 files modified
libubuntudownloadmanager/downloads/download.cpp (+8/-9) libubuntudownloadmanager/downloads/download.h (+1/-5) libubuntudownloadmanager/downloads/downloads_db.cpp (+7/-22) libubuntudownloadmanager/downloads/downloads_db.h (+0/-1) libubuntudownloadmanager/downloads/factory.cpp (+8/-17) libubuntudownloadmanager/downloads/factory.h (+0/-6) libubuntudownloadmanager/downloads/file_download.cpp (+11/-21) libubuntudownloadmanager/downloads/file_download.h (+0/-7) libubuntudownloadmanager/downloads/group_download.cpp (+2/-28) libubuntudownloadmanager/downloads/group_download.h (+2/-18) libubuntudownloadmanager/downloads/manager.cpp (+3/-9) libubuntudownloadmanager/downloads/manager.h (+0/-4) libubuntudownloadmanager/downloads/queue.cpp (+5/-5) libubuntudownloadmanager/downloads/queue.h (+1/-4) libubuntudownloadmanager/system/file_manager.cpp (+28/-0) libubuntudownloadmanager/system/file_manager.h (+16/-2) libubuntudownloadmanager/system/process_factory.cpp (+31/-0) libubuntudownloadmanager/system/process_factory.h (+14/-1) libubuntudownloadmanager/system/request_factory.cpp (+37/-0) libubuntudownloadmanager/system/request_factory.h (+17/-2) libubuntudownloadmanager/system/system_network_info.cpp (+31/-0) libubuntudownloadmanager/system/system_network_info.h (+17/-2) ubuntu-download-manager-tests/downloads/test_download.cpp (+58/-110) ubuntu-download-manager-tests/downloads/test_download_factory.cpp (+2/-2) ubuntu-download-manager-tests/downloads/test_download_factory.h (+0/-1) ubuntu-download-manager-tests/downloads/test_download_manager.cpp (+17/-21) ubuntu-download-manager-tests/downloads/test_download_queue.cpp (+3/-7) ubuntu-download-manager-tests/downloads/test_download_queue.h (+0/-1) ubuntu-download-manager-tests/downloads/test_downloads_db.cpp (+3/-8) ubuntu-download-manager-tests/downloads/test_group_download.cpp (+38/-37) ubuntu-download-manager-tests/downloads/test_group_download.h (+1/-2) ubuntu-download-manager-tests/fakes/fake_download.cpp (+2/-8) ubuntu-download-manager-tests/fakes/fake_download.h (+0/-6) ubuntu-download-manager-tests/fakes/fake_download_factory.cpp (+7/-15) ubuntu-download-manager-tests/fakes/fake_download_factory.h (+0/-6) ubuntu-download-manager-tests/fakes/fake_download_queue.cpp (+2/-3) ubuntu-download-manager-tests/fakes/fake_download_queue.h (+1/-2) |
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-download-manager/singletons |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Diego Sarmentero (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Use singletons in all those objects that have the same lifespan as the daemon.
Description of the change
Use singletons in all those objects that have the same lifespan as the daemon.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:221
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://