Merge lp://staging/~mandel/ubuntu-download-manager/remove-process-factory-pimpl into lp://staging/ubuntu-download-manager
Proposed by
Manuel de la Peña
| Status: | Merged |
|---|---|
| Approved by: | Manuel de la Peña |
| Approved revision: | 172 |
| Merged at revision: | 182 |
| Proposed branch: | lp://staging/~mandel/ubuntu-download-manager/remove-process-factory-pimpl |
| Merge into: | lp://staging/ubuntu-download-manager |
| Diff against target: |
77 lines (+3/-40) 2 files modified
libubuntudownloadmanager/system/process_factory.cpp (+3/-34) libubuntudownloadmanager/system/process_factory.h (+0/-6) |
| To merge this branch: | bzr merge lp://staging/~mandel/ubuntu-download-manager/remove-process-factory-pimpl |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Diego Sarmentero (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Remove the pimpl pattern from the ProcessFactory.
Description of the change
Remove the pimpl pattern from the ProcessFactory.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:172
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://