ubuntu-download-manager

Merge lp://staging/~mandel/ubuntu-download-manager/remove-network-reply-pimpl into lp://staging/ubuntu-download-manager

  1. remove-network-reply-pimpl
  2. Merge into trunk
Proposed by Manuel de la Peña
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 177
Merged at revision: 195
Proposed branch: lp://staging/~mandel/ubuntu-download-manager/remove-network-reply-pimpl
Merge into: lp://staging/ubuntu-download-manager
Diff against target: 392 lines (+57/-252)
5 files modified
libubuntudownloadmanager/system/network_reply.cpp (+52/-98)
libubuntudownloadmanager/system/network_reply.h (+5/-5)
ubuntu-download-manager-tests/system/test_network_reply.cpp (+0/-93)
ubuntu-download-manager-tests/system/test_network_reply.h (+0/-54)
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro (+0/-2)
To merge this branch: bzr merge lp://staging/~mandel/ubuntu-download-manager/remove-network-reply-pimpl
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Manuel de la Peña (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+195121@code.staging.launchpad.net

Commit message

Remove pimpl implementation from the NetworkReply object. Moved signals to use new way to connect.

Description of the change

Remove pimpl implementation from the NetworkReply object. Moved signals to use new way to connect.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:173
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/215/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-ci/104
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-ci/104/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-download-manager-ci/215/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:174
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/232/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-ci/121
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-ci/121/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-download-manager-ci/232/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

Approving because it is just a Jenkins error.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-autolanding/96/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-autolanding/41
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-autolanding/41/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:176
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/246/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-ci/135
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-ci/135/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/246/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Manuel de la Peña (mandel) wrote :

Looks like an issue with the armhf jenkins instance.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-autolanding/104/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-autolanding/49
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-autolanding/49/console

review: Needs Fixing (continuous-integration)
lp://staging/~mandel/ubuntu-download-manager/remove-network-reply-pimpl updated
177. By Manuel de la Peña

Remove the need of the tests because the signal connection checks are done at compile time thx to the new connection style.

Revision history for this message
Manuel de la Peña (mandel) wrote :

I'm removing the problematic tests because the connection of the signals is now performed with the new connections style and that means that the check is done at compile time.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:177
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/250/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-ci/139
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-ci/139

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/250/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches