Merge lp://staging/~mandel/ubuntu-download-manager/empty-group into lp://staging/ubuntu-download-manager

Proposed by Manuel de la Peña
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 166
Merged at revision: 166
Proposed branch: lp://staging/~mandel/ubuntu-download-manager/empty-group
Merge into: lp://staging/ubuntu-download-manager
Diff against target: 76 lines (+32/-6)
3 files modified
libubuntudownloadmanager/downloads/group_download.cpp (+11/-6)
ubuntu-download-manager-tests/downloads/test_group_download.cpp (+18/-0)
ubuntu-download-manager-tests/downloads/test_group_download.h (+3/-0)
To merge this branch: bzr merge lp://staging/~mandel/ubuntu-download-manager/empty-group
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Diego Sarmentero (community) Approve
Review via email: mp+194169@code.staging.launchpad.net

Commit message

Ensure that finished is raised when the group download is empty.

Description of the change

Ensure that finished is raised when the group download is empty.

To post a comment you must log in.
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

LGTM +1

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches