Merge lp://staging/~mandel/location-service/verbose-logging into lp://staging/location-service/trunk

Proposed by Manuel de la Peña
Status: Approved
Approved by: Jim Hodapp
Approved revision: 193
Proposed branch: lp://staging/~mandel/location-service/verbose-logging
Merge into: lp://staging/location-service/trunk
Prerequisite: lp://staging/~mandel/location-service/first-connection
Diff against target: 81 lines (+13/-3)
3 files modified
src/location_service/com/ubuntu/location/connectivity/ofono_nm_connectivity_manager.cpp (+6/-2)
src/location_service/com/ubuntu/location/non_selecting_provider_selection_policy.cpp (+5/-0)
src/location_service/com/ubuntu/location/service/daemon.cpp (+2/-1)
To merge this branch: bzr merge lp://staging/~mandel/location-service/verbose-logging
Reviewer Review Type Date Requested Status
Thomas Voß (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Jim Hodapp (community) code Approve
Review via email: mp+257572@code.staging.launchpad.net

Commit message

Add extra needed logging.

Description of the change

Add extra logging to help with future bugs.

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good

review: Approve (code)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Thomas Voß (thomas-voss) wrote :

A few comments inline.

review: Needs Fixing
194. By Manuel de la Peña

Small changes after reviews.

195. By Manuel de la Peña

Made changes according to reviews.

196. By Manuel de la Peña

Merged first-connection into verbose-logging.

Unmerged revisions

196. By Manuel de la Peña

Merged first-connection into verbose-logging.

195. By Manuel de la Peña

Made changes according to reviews.

194. By Manuel de la Peña

Small changes after reviews.

193. By Manuel de la Peña

Merged first-connection into verbose-logging.

192. By Manuel de la Peña

Increased logging.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches