Merge lp://staging/~mandel/location-service/espoo-delayed-provider into lp://staging/location-service/trunk

Proposed by Manuel de la Peña
Status: Needs review
Proposed branch: lp://staging/~mandel/location-service/espoo-delayed-provider
Merge into: lp://staging/location-service/trunk
Prerequisite: lp://staging/~mandel/location-service/delayed-providers
Diff against target: 248 lines (+151/-8)
5 files modified
include/location_service/com/ubuntu/location/provider.h (+1/-1)
src/location_service/com/ubuntu/location/provider.cpp (+11/-4)
src/location_service/com/ubuntu/location/providers/remote/provider.cpp (+136/-1)
src/location_service/com/ubuntu/location/providers/remote/provider.h (+2/-1)
tests/mock_delayed_provider.h (+1/-1)
To merge this branch: bzr merge lp://staging/~mandel/location-service/espoo-delayed-provider
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alfonso Sanchez-Beato Needs Fixing
Review via email: mp+262056@code.staging.launchpad.net

Commit message

Ensure that we use a delayed provider when the espoo service is not running.

Description of the change

Ensure that the remote provider creates a delayed provider in the case in which the service is not ready. This allows the location service to be started without having the here blobs running.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
210. By Manuel de la Peña

Add extra logging to keep track of the remote daemon.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM, just have some minor nits. See comments below.

review: Needs Fixing
211. By Manuel de la Peña

Track ownership change of the service to check if the name changed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
212. By Manuel de la Peña

Add some extra logging for debugging purposes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
213. By Manuel de la Peña

Increase logging to know what the provider is not started.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

213. By Manuel de la Peña

Increase logging to know what the provider is not started.

212. By Manuel de la Peña

Add some extra logging for debugging purposes.

211. By Manuel de la Peña

Track ownership change of the service to check if the name changed.

210. By Manuel de la Peña

Add extra logging to keep track of the remote daemon.

209. By Manuel de la Peña

Use the new method to get the signal.

208. By Manuel de la Peña

Merged delayed-providers into espoo-delayed-provider.

207. By Manuel de la Peña

Ensure that we connect to the booted signal.

206. By Manuel de la Peña

Merged delayed-providers into espoo-delayed-provider.

205. By Manuel de la Peña

Make the remote provider work when the daemons have not been launched.

204. By Manuel de la Peña

Merged with tvoss work to make the boot more reliable.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches