ADCH++

Merge lp://staging/~maksis/adchpp/adchpp-hbri into lp://staging/adchpp

  1. adchpp-hbri
  2. Merge into trunk
Proposed by maksis
Status: Needs review
Proposed branch: lp://staging/~maksis/adchpp/adchpp-hbri
Merge into: lp://staging/adchpp
Diff against target: 1149 lines (+457/-101)
19 files modified
adchpp/AdcCommand.cpp (+1/-1)
adchpp/AdcCommand.h (+5/-1)
adchpp/Client.h (+2/-0)
adchpp/ClientManager.cpp (+229/-55)
adchpp/ClientManager.h (+12/-2)
adchpp/Entity.cpp (+37/-3)
adchpp/Entity.h (+12/-1)
adchpp/ManagedSocket.cpp (+38/-2)
adchpp/ManagedSocket.h (+7/-1)
adchpp/ServerInfo.h (+4/-1)
adchpp/SocketManager.cpp (+65/-26)
adchpp/SocketManager.h (+4/-0)
adchpp/Util.cpp (+5/-1)
adchpp/Util.h (+2/-1)
adchppd/adchppd.cpp (+7/-0)
changelog.txt (+7/-0)
etc/adchpp.xml (+13/-2)
swig/adchpp.i (+6/-3)
swig/lua.i (+1/-1)
To merge this branch: bzr merge lp://staging/~maksis/adchpp/adchpp-hbri
Reviewer Review Type Date Requested Status
Dcplusplus-team Pending
Review via email: mp+194959@code.staging.launchpad.net

Description of the change

* Add support for hybrid IPv4/IPv6 client connectivity: http://www.dcbase.org/forum/viewtopic.php?f=55&t=771
* [L#1088638] Allow clients to reconnect in event of overflow
* [L#1106226] Fix a crash when joining the hub with a local IPv6 address
* Make login timeout work independently from other connecting users
* Allow configuring custom bind addresses

To post a comment you must log in.
Revision history for this message
poy (poy) wrote :

hmm, it's unfortunate i forgot to answer that forum post but i still don't see why this has to be a new extension, and especially why it needs a new extension.

i exposed a simpler alternative here: <https://bugs.launchpad.net/adchpp/+bug/309402/comments/40>

it relies on the quality of the PID/CID system, which is assumed to be reliable in ADC where hubs are trusted.

Reply
Revision history for this message
poy (poy) wrote :

> hmm, it's unfortunate i forgot to answer that forum post but i still don't see
> why this has to be a new extension, and especially why it needs a new
> extension.

especially why it needs a new ADC command*

Reply
Revision history for this message
maksis (maksis) wrote :

> hmm, it's unfortunate i forgot to answer that forum post

I don't think that it's too late yet. Starting a third thread for protocol discussion makes it even more difficult to track later.

Reply
lp://staging/~maksis/adchpp/adchpp-hbri updated
661. By maksis

Remove string::pop_back() for better compatibility

Revision history for this message
Janne (barajag) wrote :

it's fun to see Maksis work as usual. fix the big bugs too while you are working hehe
Nice work m8

Reply
Revision history for this message
Janne (barajag) wrote :

is Adch++ dead now or what??????????

Reply
lp://staging/~maksis/adchpp/adchpp-hbri updated
662. By maksis

Don't strip supports for the secondary IP protocol on INF updates

663. By maksis

Merge

664. By maksis

Merge

665. By maksis

Sync

Unmerged revisions

665. By maksis

Sync

664. By maksis

Merge

663. By maksis

Merge

662. By maksis

Don't strip supports for the secondary IP protocol on INF updates

661. By maksis

Remove string::pop_back() for better compatibility

660. By maksis

Readd 629 and 630

659. By maksis

Revert some changes, update changelog

658. By maksis

- Remove extra TCP/UDP supports from clients
- Dont advertise the HBRI support if there is no configured hub address for both protocols

657. By maksis

HBRI works also for registered users

656. By maksis

Resolve the configured hub addresses, bug fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches