Merge lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/oerp6.1-stable-nocheck_tracking-1108643 into lp://staging/magentoerpconnect/oerp6.1-stable
Proposed by
Guewen Baconnier @ Camptocamp
| Status: | Merged |
|---|---|
| Merged at revision: | 690 |
| Proposed branch: | lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/oerp6.1-stable-nocheck_tracking-1108643 |
| Merge into: | lp://staging/magentoerpconnect/oerp6.1-stable |
| Diff against target: |
45 lines (+10/-7) 1 file modified
magentoerpconnect/stock.py (+10/-7) |
| To merge this branch: | bzr merge lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/oerp6.1-stable-nocheck_tracking-1108643 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandre Fayolle - camptocamp | code review, no test | Approve | |
|
Review via email:
|
|||
Commit message
[FIX] do not check if the carrier exists in getCarrier if there is no tracking number, do not send an empty tracking number
Description of the change
Fix for bug lp:1108643
Skip the check and creation of a tracking number if the tracking number is empty.
Currently, the check prevent to export a picking if the carrier is not in the
Magento's 'getCarriers' list.
To post a comment you must log in.
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Approve
(code review, no test)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Same fix for oerp6.1-oldstable: https:/