Merge lp://staging/~maddevelopers/mg5amcnlo/3.0.4-qcdonly into lp://staging/~maddevelopers/mg5amcnlo/3.0.4

Proposed by Olivier Mattelaer
Status: Merged
Merged at revision: 996
Proposed branch: lp://staging/~maddevelopers/mg5amcnlo/3.0.4-qcdonly
Merge into: lp://staging/~maddevelopers/mg5amcnlo/3.0.4
Diff against target: 490 lines (+165/-46)
10 files modified
Template/NLO/Cards/FKS_params.dat (+1/-1)
madgraph/fks/fks_base.py (+29/-4)
madgraph/fks/fks_common.py (+8/-5)
madgraph/interface/amcatnlo_interface.py (+94/-22)
madgraph/interface/common_run_interface.py (+9/-3)
madgraph/interface/madgraph_interface.py (+11/-4)
madgraph/interface/master_interface.py (+4/-4)
madgraph/iolibs/export_fks.py (+2/-0)
madgraph/iolibs/export_v4.py (+5/-2)
madgraph/various/banner.py (+2/-1)
To merge this branch: bzr merge lp://staging/~maddevelopers/mg5amcnlo/3.0.4-qcdonly
Reviewer Review Type Date Requested Status
marco zaro Approve
Review via email: mp+399657@code.staging.launchpad.net

Commit message

add an option
set mixed_coupling_expansion T/F (default T)
to go back to v2 mode of generation of loop/CT.
However the new v3 phase-space is very very slow and that is handle...

To post a comment you must log in.
996. By marco zaro

fix for bug https://bugs.launchpad.net/mg5amcnlo/+bug/1918942
The problem was that the coupling hierarchy was hardcoded to be 1 for QCD and 2 for QED,
while this is not the case in general

997. By olivier-mattelaer

reset NHelForMCoverHels to official default + avoid forcing widht to 0 in pure QCD case

998. By olivier-mattelaer

merge with latest 3.0.4 (including 2.9.3)

Revision history for this message
marco zaro (marco-zaro) wrote :

Hi Olivier,
the changes to the code look fine.
As I wrote you on skype, I would warn the user if one has nlo_mixed_expansion = False but the LO diagrams have more than one coupling combination. While this may be OK in some cases (EFT), it may be completely wrong in other (I guess for these cases one has check-poles failing, etc..)

Thanks a lot!

Cheers,

Marco

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: