MadGraph5_aMC@NLO

Merge lp://staging/~maddevelopers/mg5amcnlo/2.6.1_lhapdf62 into lp://staging/~mg5core2/mg5amcnlo/2.6.1

  1. 2.6.1_lhapdf62
  2. Merge into 2.6.1
Proposed by marco zaro
Status: Merged
Merged at revision: 304
Proposed branch: lp://staging/~maddevelopers/mg5amcnlo/2.6.1_lhapdf62
Merge into: lp://staging/~mg5core2/mg5amcnlo/2.6.1
Diff against target: 1593 lines (+1576/-2)
2 files modified
Template/NLO/Source/PDF/makefile (+7/-2)
Template/NLO/Source/PDF/pdf_lhapdf62.cc (+1569/-0)
To merge this branch: bzr merge lp://staging/~maddevelopers/mg5amcnlo/2.6.1_lhapdf62
Reviewer Review Type Date Requested Status
Olivier Mattelaer Approve
Rikkert Frederix Pending
Review via email: mp+331340@code.staging.launchpad.net

Description of the change

Small changes in order to have LHAPDF 6.2 working. Compatibility with 6.1X is kept. Eventually, the pdf_lhapdf62.cc will probably be removed in favour of the LHAPDF fortran interface functions

To post a comment you must log in.
Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Hi Marco,

Thanks for this is works really nicely.
At the same time, I would prefer to move to a complete fortran interface such that we do not have to rely on that c++ script.
I will try to move on that new interface (but if you want to do it) and then we will see if we include this or not.

Cheers and thanks,

Olivier

review: Abstain
Revision history for this message
marco zaro (marco-zaro) wrote :

Hi Olivier,
in practice, what shall we do?
I would tend to make the support to LHAPDF6.2 available asap (so in 2.6.1). So I think that if we manage to have a cleaner version of the wrapper functions by the 2.6.1 release then we drop this branch, otherwise we should merge it. The changes are trivial, so merging at a later stage or even just before the release should still be ok.
What do you think?

Cheers,

Marco

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Yes I fully agree on that.

Olivier
> On 2 Oct 2017, at 09:44, marco zaro <email address hidden> wrote:
>
> Hi Olivier,
> in practice, what shall we do?
> I would tend to make the support to LHAPDF6.2 available asap (so in 2.6.1). So I think that if we manage to have a cleaner version of the wrapper functions by the 2.6.1 release then we drop this branch, otherwise we should merge it. The changes are trivial, so merging at a later stage or even just before the release should still be ok.
> What do you think?
>
> Cheers,
>
> Marco
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.6.1_lhapdf62/+merge/331340
> You are reviewing the proposed merge of lp:~maddevelopers/mg5amcnlo/2.6.1_lhapdf62 into lp:~mg5core2/mg5amcnlo/2.6.1.

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Did not have the time to really move forward on this, so I will merge this branch.
Thanks Marco.

Olivier

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: