Unity 8

Merge lp://staging/~macslow/unity8/swipe-dismiss-snap-decisions into lp://staging/unity8

swipe-dismiss-snap-decisions
Merge into trunk

Proposed by Mirco Müller on 2014-09-04

Status:

Merged

Approved by:

Michał Sawicz on 2015-02-09

Approved revision:

1285

Merged at revision:

1599

Proposed branch:

lp://staging/~macslow/unity8/swipe-dismiss-snap-decisions

Merge into:

lp://staging/unity8

Diff against target:

1554 lines (+836/-252)

15 files modified

qml/Notifications/Notification.qml (+36/-6)
qml/Notifications/Notifications.qml (+2/-6)
tests/mocks/Unity/Notifications/CMakeLists.txt (+2/-1)
tests/mocks/Unity/Notifications/MockActionModel.cpp (+6/-4)
tests/mocks/Unity/Notifications/MockActionModel.h (+4/-2)
tests/mocks/Unity/Notifications/MockNotification.cpp (+156/-4)
tests/mocks/Unity/Notifications/MockNotification.h (+63/-5)
tests/mocks/Unity/Notifications/MockNotificationModel.cpp (+172/-0)
tests/mocks/Unity/Notifications/MockNotificationModel.h (+72/-0)
tests/mocks/Unity/Notifications/plugin.cpp (+5/-3)
tests/mocks/Unity/Notifications/plugin.h (+1/-2)
tests/qmltests/Notifications/Notification.qml (+31/-0)
tests/qmltests/Notifications/tst_Notifications.qml (+271/-213)
tests/qmltests/Notifications/tst_OptionToggle.qml (+11/-6)
tests/qmltests/Notifications/tst_SwipeToAct.qml (+4/-0)

To merge this branch:

bzr merge lp://staging/~macslow/unity8/swipe-dismiss-snap-decisions

Related bugs:

Bug #1334855: [notifications] Can't use toolbar while notifications on screen	Medium	Fix Released
Bug #1355422: [notifications] Can't dismiss notification bubbles	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz	tests		Approve on 2015-02-09
PS Jenkins bot (community)	continuous-integration	2014-09-04	Approve on 2015-02-09
Albert Astals Cid (community)			Approve on 2015-01-27
Michael Zanetti (community)			Abstain on 2014-11-24
Antti Kaijanmäki (community)			Needs Information on 2014-11-08
Review via email: mp+233347@code.staging.launchpad.net

Commit message

Allow swipe-to-dismiss for contracted snap-decision notifications, interactive notifications and ephemeral notifications.

Description of the change

Allow swipe-to-dismiss for contracted snap-decision notifications, interactive notifications and ephemeral notifications.

For the reviewers convenience, here's a video of the branch in action: https://www.youtube.com/watch?v=3kHuR-3Mns0

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Yes.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-04:

#

FAILED: Continuous integration, rev:1089
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~macslow/unity8/swipe-dismiss-snap-decisions/+merge/233347/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity8-ci/4230/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4444
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1324
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1324
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4219
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5696
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5696/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12647

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4230/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-04:

#

FAILED: Continuous integration, rev:1230
http://jenkins.qa.ubuntu.com/job/unity8-ci/4235/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4454
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1236
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1329
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4228
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5706
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5706/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12654

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4235/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-16:

#

FAILED: Continuous integration, rev:1233
http://jenkins.qa.ubuntu.com/job/unity8-ci/4319/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4845/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1320
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1413
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1413
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4607/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6097
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6097/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13249

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4319/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-30:

#

FAILED: Continuous integration, rev:1234
http://jenkins.qa.ubuntu.com/job/unity8-ci/4446/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5326
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1442
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1540
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1540
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5041
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6578
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6578/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13933

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4446/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-30:

#

FAILED: Continuous integration, rev:1235
http://jenkins.qa.ubuntu.com/job/unity8-ci/4452/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5339
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1448
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1546
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1546
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5051
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6591
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6591/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13947

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4452/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-20:

#

FAILED: Continuous integration, rev:1331
http://jenkins.qa.ubuntu.com/job/unity8-ci/4698/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6052/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1684
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1794
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1792
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5686/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7304
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7304/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14849

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4698/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-10-31:

#

Text conflict in qml/Notifications/Notification.qml
1 conflicts encountered.

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-05:

#

Text conflict in qml/Notifications/Notification.qml
Text conflict in tests/qmltests/Notifications/tst_Notifications.qml
2 conflicts encountered.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-08:

#

FAILED: Continuous integration, rev:1236
http://jenkins.qa.ubuntu.com/job/unity8-ci/4857/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/62
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/34/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/62
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/62/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4857/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-08:

#

FAILED: Continuous integration, rev:1236
http://jenkins.qa.ubuntu.com/job/unity8-ci/4859/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/66
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/24
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/66
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/66/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15581

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4859/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Antti Kaijanmäki (kaijanmaki) wrote on 2014-11-08:

#

+ readonly property bool draggable: state == "contracted" || notification.type !== Notification.Confirmation

Does this cover pin-unlock dialog as well? I don't have the code at hand right now to check if it's type is set to Notification.Confirmation as otherwise it becomes draggable.

review: Needs Information

Revision history for this message

Mirco Müller (macslow) wrote on 2014-11-09:

#

> + readonly property bool draggable: state == "contracted" ||
> notification.type !== Notification.Confirmation
>
>
> Does this cover pin-unlock dialog as well? I don't have the code at hand right
> now to check if it's type is set to Notification.Confirmation as otherwise it
> becomes draggable.

No, that won't happen. A SIM-unlock "dialog" is an expanded (or non-contractable) snap-decision, thus it cannot be dragged.

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-10:

#

file:///tmp/buildd/unity8-8.01+15.04.20141104bzr1236pkg0vivid36/tests/qmltests/Notifications/tst_Notifications.qml:672:13: Unexpected token `if'
                 if (data.type !== Notification.SnapDecision && notification.state !== "expanded") {
                 ^
file:///tmp/buildd/unity8-8.01+15.04.20141104bzr1236pkg0vivid36/tests/qmltests/Notifications/tst_Notifications.qml:672:16: Expected a qualified name id
                 if (data.type !== Notification.SnapDecision && notification.state !== "expanded") {

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-12:

#

make testNotifications fails here

review: Needs Fixing

Revision history for this message

Mirco Müller (macslow) wrote on 2014-11-12:

#

> make testNotifications fails here

Like discussed on IRC, I can't reproduce your reported failures. Everything works and passes as expected.

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-12:

#

> > make testNotifications fails here
>
> Like discussed on IRC, I can't reproduce your reported failures. Everything
> works and passes as expected.

Barring that for some reasons test don't pass for me the rest looks good, if everyone else wants to take over these two days i'm out, feel free :)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-12:

#

PASSED: Continuous integration, rev:1241
http://jenkins.qa.ubuntu.com/job/unity8-ci/4891/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/171
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/161
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/171
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/171/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15760

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4891/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-13:

#

I can reproduce the test failures Albert reported. Sometimes it seems that a swipe to remove removes 2 notifications instead of just one. I can also reproduce that manually with tryNotifications.

review: Needs Fixing

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-13:

#

Seems fixing the FIXME in Notifications.qml:44 fixes this. Can't reproduce the issue any more neither using the test, nor manually.

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-13:

#

hmm.. sorry, after reverting the debug prints in the test it fails again here...

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-24:

#

Test passing fine now.

review: Abstain

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-24:

#

I think relying on the JS->C++ binding ignoring the extra parameter to call an invokable function with less parameters is a bit too much

Revision history for this message

Albert Astals Cid (aacid) wrote on 2015-01-27:

#

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass?
Waiting for it to finish

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-27:

#

FAILED: Continuous integration, rev:1282
http://jenkins.qa.ubuntu.com/job/unity8-ci/5193/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1016/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/357/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1014/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5193/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-27:

#

FAILED: Continuous integration, rev:1282
http://jenkins.qa.ubuntu.com/job/unity8-ci/5195/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1019
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/359/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/360
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/899
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1017
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1017/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17506

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5195/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2015-01-27:

#

qmluitests failed on CI for some reason byt they all passed fine so i'm going to top approve anyway

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-27:

#

FAILED: Continuous integration, rev:1282
http://jenkins.qa.ubuntu.com/job/unity8-ci/5196/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1020/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/361
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/361
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/901/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1018
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1018/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17508

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5196/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-02-04:

#

There's a failing test I'm afraid:

FAIL! : qmltestrunner::NotificationRendererTest::test_NotificationRenderer(Ephemeral notification) property count
   Actual (): 3
   Expected (): 2
   Loc: [/home/michal/Pobrane/unity8-8.02+15.04.20150204.1/tests/qmltests/Notifications/tst_Notifications.qml(666)]

review: Needs Fixing

Revision history for this message

Mirco Müller (macslow) wrote on 2015-02-04:

#

Looking into it.

lp://staging/~macslow/unity8/swipe-dismiss-snap-decisions updated on 2015-02-05

1284. By Mirco Müller on 2015-02-05: Merge with trunk.

Revision history for this message

Mirco Müller (macslow) wrote on 2015-02-05:

#

I've updated my system, re-merged this branch with lp:unity8 trunk and recompiled everything, but still can't reproduce this failure. All notification-related qml-tests pass.

lp://staging/~macslow/unity8/swipe-dismiss-snap-decisions updated on 2015-02-06

1285. By Mirco Müller on 2015-02-06: Make sure all rendering operations are completed before doing the swipe-dismiss-checks, thus the tests also pass on very slow (jenkins) systems.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

#

FAILED: Continuous integration, rev:1285
http://jenkins.qa.ubuntu.com/job/unity8-ci/5254/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1221
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/418/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/419/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/419
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1077
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1219
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1219/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17851

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5254/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-09:

#

PASSED: Continuous integration, rev:1285
http://jenkins.qa.ubuntu.com/job/unity8-ci/5260/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1251
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/424
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1249
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1249/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17888

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5260/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) on 2015-02-09:

#

review: Approve (tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Mirco Müller

Mohammad Rakibul Hasan

Unity Team