Unity 8

Merge lp://staging/~macslow/unity8/icon-clipping-fix-1378417 into lp://staging/unity8

icon-clipping-fix-1378417
Merge into trunk

Proposed by Mirco Müller on 2014-11-07

Status:

Merged

Approved by:

Andrea Cimitan on 2014-11-10

Approved revision:

1422

Merged at revision:

1439

Proposed branch:

lp://staging/~macslow/unity8/icon-clipping-fix-1378417

Merge into:

lp://staging/unity8

Diff against target:

11 lines (+1/-1)

1 file modified

qml/Notifications/ShapedIcon.qml (+1/-1)

To merge this branch:

bzr merge lp://staging/~macslow/unity8/icon-clipping-fix-1378417

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-11-17
Andrea Cimitan (community)		2014-11-07	Approve on 2014-11-10
Review via email: mp+241097@code.staging.launchpad.net

Commit message

Make sure non-square icons are not cropped.

Description of the change

Make sure non-square icons are not cropped.

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4854/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-08:

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/4860/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/25
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/70
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/67
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15582

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4860/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Andrea Cimitan (cimi) wrote on 2014-11-10:

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
autopilot
* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-17:

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/4902/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/220
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/79
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/67
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/220
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/220/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15869