unity-notifications

Merge lp://staging/~macslow/unity-notifications/sound-hint-support into lp://staging/unity-notifications

  1. sound-hint-support
  2. Merge into trunk
Proposed by Mirco Müller
Status: Merged
Approved by: Michał Sawicz
Approved revision: 204
Merged at revision: 210
Proposed branch: lp://staging/~macslow/unity-notifications/sound-hint-support
Merge into: lp://staging/unity-notifications
Diff against target: 166 lines (+117/-0)
5 files modified
examples/example.py (+6/-0)
examples/sound.py (+53/-0)
examples/suppress-sound.py (+54/-0)
include/notify-backend.h.in (+2/-0)
src/NotificationServer.cpp (+2/-0)
To merge this branch: bzr merge lp://staging/~macslow/unity-notifications/sound-hint-support
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+218961@code.staging.launchpad.net

Commit message

Added the backend-part of sound-hint support with two additional examples demonstrating its use.

Description of the change

Added the backend-part of sound-hint support with two additional examples demonstrating its use.

* Are there any related MPs required for this MP to build/function as expected?
Not applicable.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:203
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/61/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/61/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Minor comments inline.

review: Needs Fixing
lp://staging/~macslow/unity-notifications/sound-hint-support updated
204. By Mirco Müller

Fixed identation.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:204
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/64/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-utopic-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/64/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Yes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: