Merge lp://staging/~macslow/unity-notifications/modal-snap-decisions into lp://staging/unity-notifications

Hmm... I think this should rather be defined in lp:unity-api and teted for its existence here in tst_NotificaitonInterface.qml, no?

PASSED: Continuous integration, rev:201
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/49/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/49/rebuild

Yeah, please submit a similar thing to lp:unity-api, even though this is not using it yet (it should!), let's keep it as close as possible.

Just working on that.

Here's the Unity-API MP going alongside this one https://code.launchpad.net/~macslow/unity-api/expose-notification-data-roles-to-qml/+merge/212581

Even though this model doesn't inherit the one from unity-api yet, I'm wondering if it wouldn't make sense to already now use the enums in there. Without having tested it, do you think we could just drop the enum definition in here and use ModelInterface::Roles everywhere in here already? Otherwise I see it drifting apart again.

Ill will make sure we can use the enum from unity-api as drop-in here and see that it will still work (or make it work) with https://code.launchpad.net/~macslow/unity8/modal-snap-decisions/+merge/210988

FAILED: Continuous integration, rev:202
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/50/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/25/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/50/rebuild

FAILED: Continuous integration, rev:204
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/51/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/26/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/51/rebuild

Q_ENUMS(Roles) seems like it should go away

PASSED: Continuous integration, rev:204
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/52/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/27
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/27/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/27

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/52/rebuild

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, still works

* Did CI run pass? If not, please explain why.
Yes.

PASSED: Continuous integration, rev:205
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/53/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/28
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/28

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/53/rebuild

This needs a bump in unity-notifications-impl provided, to go with a bump in a .pc file bump in unity-api.

See https://code.launchpad.net/~macslow/unity8/modal-snap-decisions/+merge/210988/comments/512330 for details.

FAILED: Continuous integration, rev:206
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/54/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/29/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/54/rebuild

You're right, in a sense, that this implements both v2 and v3 of the Notifications API, but I don't think we're at the point where we care. Just drop the -impl-2 and replace with -impl-3 please.

The whole idea is like so:
unity-api defines the API by providing headers, for each group of interfaces (application, notifications etc.), there's a pkg-config file (i.e. unity-notifications.pc), which in the Version field defines the version of the API implemented. Right now it's manual, but we'll make it automagic, that unity-notifications-impl-$version will be generated from this .pc file.

Then, any consumer of this API (unity8 in our case) depends on $default-implementation-real-package | unity-$interface-impl, unity-$interface-impl-$version. We wouldn't need the first bit, but dpkg would choke on only-virtual dependency like that.

On top of that, the unity-api tests will be ran against the actual implementation to verify the expected API.

Makes some sense now? The idea is to ensure shell-facing API stability and allow for easy drop-in replacements, as long as they implement the same interfaces.

This needs to build-depend on libunity-api-dev >= 7.80.7.

FAILED: Continuous integration, rev:207
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/55/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/30/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/55/rebuild

18 + unity-notifications-impl-2,
19 + unity-notifications-impl-3

See my previous comment - replace, don't add.

=====

54 +pkg_check_modules(NOTIFICATIONS_API REQUIRED unity-shell-notifications=1)

This version should be the same as -impl, so 3.

=====

76 +/* check if unity-api >= 0.1.3 */
77 +#include <unity/api/Version.h>
78 +#if UNITY_API_VERSION_MAJOR > 0 || \
79 + (UNITY_API_VERSION_MAJOR == 0 && (UNITY_API_VERSION_MINOR > 1 || \
80 + (UNITY_API_VERSION_MINOR == 1 && \
81 + UNITY_API_VERSION_MICRO < 3)))
82 + #error Unity-API needs to be at least 0.1.3
83 +#endif

You're not using that part of unity-api at all, so all that is not needed.

FAILED: Continuous integration, rev:208
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/57/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/32/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/32/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/32/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/57/rebuild

See https://code.launchpad.net/~macslow/unity-api/version-bump-to-0.1.3/+merge/217882/comments/518636, bump the build-depends to (>= 7.80.8).

Also, parentheses are required in dependencies!

You might want to run `wrap-and-sort -atv` to make sure of all the formatting in debian/ is good.

FAILED: Continuous integration, rev:209
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/58/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/33/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/58/rebuild

FAILED: Continuous integration, rev:210
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/59/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-amd64-ci/34/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-armhf-ci/34/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-notifications-trusty-i386-ci/34/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-notifications-ci/59/rebuild

Yup.