Merge lp://staging/~macslow/unity-notifications/fix-1308011 into lp://staging/unity-notifications
Proposed by
Mirco Müller
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz |
| Approved revision: | 213 |
| Merged at revision: | 213 |
| Proposed branch: | lp://staging/~macslow/unity-notifications/fix-1308011 |
| Merge into: | lp://staging/unity-notifications |
| Diff against target: |
23 lines (+5/-0) 2 files modified
include/Notification.h (+1/-0) src/Notification.cpp (+4/-0) |
| To merge this branch: | bzr merge lp://staging/~macslow/unity-notifications/fix-1308011 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Michał Sawicz | Approve | ||
|
Review via email:
|
|||
Commit message
Added close() q_invokable to allow notifications to be closed from the renderer (unity8) side. This facilitates fixing LP:1308011
Description of the change
Added close() q_invokable to allow notifications to be closed from the renderer (unity8) side. This facilitates fixing LP:1308011
- Are there any related MPs required for this MP to build/function as expected?
No
- Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
- Did you make sure that your branch does not contain spurious tags?
Yes
- If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
- If you changed the UI, has there been a design review?
Not applicable
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks fine.