phone-app

Merge lp://staging/~macslow/phone-app/fix-1194629 into lp://staging/phone-app

  1. fix-1194629
  2. Merge into trunk
Proposed by Mirco Müller
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 696
Merged at revision: 697
Proposed branch: lp://staging/~macslow/phone-app/fix-1194629
Merge into: lp://staging/phone-app
Diff against target: 15 lines (+1/-4)
1 file modified
approver/phoneappapprover.cpp (+1/-4)
To merge this branch: bzr merge lp://staging/~macslow/phone-app/fix-1194629
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+171485@code.staging.launchpad.net

Commit message

Don't use the image_path hint to pass an avatar-icon, because the notification-backend does not support it yet. Instead use notify_notification_new()s icon-parameter directly.

Description of the change

Don't use the image_path hint to pass an avatar-icon, because the notification-backend does not support it yet. Instead use notify_notification_new()s icon-parameter directly. Fixes LP: #1194629

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:696
http://jenkins.qa.ubuntu.com/job/phone-app-ci/157/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/375
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phone-app-saucy-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phone-app-saucy-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/phone-app-saucy-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phone-app-saucy-i386-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/377
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/377/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/343

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phone-app-ci/157/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches