Notify OSD

Merge lp://staging/~macslow/notify-osd/fix.810325-2 into lp://staging/~canonical-dx-team/notify-osd/precise

  1. fix.810325-2
  2. Merge into precise
Proposed by Mirco Müller
Status: Merged
Approved by: Mirco Müller
Approved revision: 451
Merged at revision: 452
Proposed branch: lp://staging/~macslow/notify-osd/fix.810325-2
Merge into: lp://staging/~canonical-dx-team/notify-osd/precise
Diff against target: 177 lines (+87/-8)
3 files modified
src/bubble.c (+13/-7)
src/defaults.c (+73/-1)
src/defaults.h (+1/-0)
To merge this branch: bzr merge lp://staging/~macslow/notify-osd/fix.810325-2
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+92000@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-02-08.

Description of the change

Updated version of the branch for supporting tinting the notification-bubble background with the average color pulled from the Unity schema. This is optional and checked at runtime if available. So if notify-osd is run under a system without Unity or with an older Unity not providing the average-color, notify-osd just falls back to the regular dark grey tint.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The code seems fine for me but I can't test since Unity 5.2 doesn't seem to include the key you are using, is that pending an Unity merge to land?

Revision history for this message
Mirco Müller (macslow) wrote :

Yes, the unity-part of this is in unity trunk to be released with 5.4.

Revision history for this message
Mirco Müller (macslow) wrote :

I just want to make sure I get this into a notify-osd release so it doesn't slip feature freeze.

Revision history for this message
Sebastien Bacher (seb128) wrote :

well, approving since the code seems fine assuming that you test ran it with an unity having the required changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches