Merge lp://staging/~macobo/mailman/macobo-rcpt-stage-reject into lp://staging/mailman
Proposed by
Karl-Aksel Puulmann
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~macobo/mailman/macobo-rcpt-stage-reject |
| Merge into: | lp://staging/mailman |
| Diff against target: |
82 lines (+48/-0) 2 files modified
src/mailman/runners/lmtp.py (+18/-0) src/mailman/runners/tests/test_lmtp.py (+30/-0) |
| To merge this branch: | bzr merge lp://staging/~macobo/mailman/macobo-rcpt-stage-reject |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mailman Coders | Pending | ||
|
Review via email:
|
|||
Description of the change
It probably needs a little more work before merging.
Open questions:
1) Is the test naming okay?
2) Should the tests be done in a different way? I didn't find any other tests that used the mock library.
3) Should the mocking be done within the setUp stage?
4) If that's okay, should get_mocked_
To post a comment you must log in.
Unmerged revisions
- 7213. By Karl-Aksel Puulmann
-
Remove white-space added by mistake
- 7212. By Karl-Aksel Puulmann
-
Moved get_mocked_
lmtp_channel to top of file - 7211. By Karl-Aksel Puulmann
-
Fixed a LMTP bug, causing it not to validate email list addresses until DATA stage. (LP: 982555)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
