Unwrapt

Merge lp://staging/~mac9416/unwrapt/dependency_statuses into lp://staging/unwrapt

  1. dependency_statuses
  2. Merge into stable
Proposed by mac9416
Status: Merged
Merge reported by: Chris Oliver
Merged at revision: not available
Proposed branch: lp://staging/~mac9416/unwrapt/dependency_statuses
Merge into: lp://staging/unwrapt
Diff against target: 282 lines (+57/-42)
3 files modified
example.py (+4/-1)
unwrapt/DefinitionBase.py (+5/-2)
unwrapt/definitions/aptdef/__init__.py (+48/-39)
To merge this branch: bzr merge lp://staging/~mac9416/unwrapt/dependency_statuses
Reviewer Review Type Date Requested Status
Chris Oliver Approve
Review via email: mp+32369@code.staging.launchpad.net

This proposal supersedes a proposal from 2010-08-11.

Description of the change

Started work on the dependency package statuses. I say "statuses" because there will have to be one for "to be downloaded" and "to be installed".

I have everything in order except getting on_mark_package to mark the top-level package as "to be donwloaded" and the dependencies as "dependency to be downloaded". See huge comment at top of on_mark_package.

I also dropped a few unrelated TODOs, FIXMEs, and improvements.

To post a comment you must log in.
Revision history for this message
mac9416 (mac9416) wrote :

I resubmitted the request because I _think_ I have dependency statuses implemented. I added a `dependency` argument to the mark_package function that is False by default but True when mark_package calls itself.

Ingenious, eh?

Revision history for this message
Chris Oliver (excid3) wrote :

Exactly how I planned on doing it. :D Reviewing it now, but it looks great so far!

Revision history for this message
Chris Oliver (excid3) wrote :

Good good good upgrade to the url_join function. I noticed it was annoying me nesting it, but I did not even think of fixing that. Thanks!! :D

Revision history for this message
Chris Oliver (excid3) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches