Keryx

Merge lp://staging/~mac9416/keryx/keryx-1.0 into lp://staging/keryx/unstable

  1. keryx-1.0
  2. Merge into unstable
Proposed by mac9416
Status: Merged
Merged at revision: 36
Proposed branch: lp://staging/~mac9416/keryx/keryx-1.0
Merge into: lp://staging/keryx/unstable
Diff against target: 494 lines (+133/-148)
4 files modified
.bzrignore (+5/-5)
bin/keryx (+119/-69)
data/ui/KeryxWindow.ui (+5/-70)
keryx/keryxconfig.py (+4/-4)
To merge this branch: bzr merge lp://staging/~mac9416/keryx/keryx-1.0
Reviewer Review Type Date Requested Status
Senthil Kumar_Webrsk (community) Approve
Keryx Admins Pending
Review via email: mp+36507@code.staging.launchpad.net

Description of the change

"Code‽ I don't have time to code! There's hay to be bailed and cows to be milked and..."

Anyway, I made some time to code. I managed to implement the Download button and the Installed Version text. That required an additional function in Unwrapt, mind you, (merge request for that coming soon) so be sure to update both branches before testing.

I'm adding RSK as a reviewer.

To post a comment you must log in.
Revision history for this message
mac9416 (mac9416) wrote :

Bah, looks like I forgot to push the last batch of code into unstable. RSK, you'll just have to skim over old stuff. :-)

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote :

> Bah, looks like I forgot to push the last batch of code into unstable. RSK,
> you'll just have to skim over old stuff. :-)

So do i have to take 63 revision of lp:~mac9416/keryx/unwrapt ?

Revision history for this message
mac9416 (mac9416) wrote :

> So do i have to take 63 revision of lp:~mac9416/keryx/unwrapt ?

Yes, for this revision of Keryx, you'll have to have the latest Unwrapt revision from my branch as well.

To make Keryx able to import Unwrapt, you'll have to create a link at keryx/unwrapt to the unwrapt directory in your local Unwrapt branch. If keryx/unwrapt already exists, replace it with your new link.

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote :

When i try to manage the computer it fails to download the index files. As per the code it should proceed further but it raises more error.
Reading packing lists... 46%Traceback
IOError:Not a gzipped file

review: Needs Information
Revision history for this message
mac9416 (mac9416) wrote :

I've encountered that error too. By adding a print statement to the index file reading code in Unwrapt, I was able to see that it was a Medibuntu index file that threw the error. Opening the file with an archive app worked perfectly fine.
Even more befuddling is that the error occurs on my 64-bit Studio desktop, but not my 32-bit Lubuntu laptop. I'll test on another 32-bit machine and see what happens.

At any rate, you can disable whatever repos are causing the error and continue testing. I'll send a message to the mailing list that this needs looking into.

Revision history for this message
mac9416 (mac9416) wrote :

Hey, RSK, I'm going to go on and merge this in. If there are any serious issues, we'll iron them out later.

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote :

Ya we can proceed merging :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: