Merge lp://staging/~mac9416/keryx/keryx-1.0 into lp://staging/~excid3/keryx/keryx-1.0

Proposed by mac9416
Status: Needs review
Proposed branch: lp://staging/~mac9416/keryx/keryx-1.0
Merge into: lp://staging/~excid3/keryx/keryx-1.0
Diff against target: 494 lines (+133/-148)
4 files modified
.bzrignore (+5/-5)
bin/keryx (+119/-69)
data/ui/KeryxWindow.ui (+5/-70)
keryx/keryxconfig.py (+4/-4)
To merge this branch: bzr merge lp://staging/~mac9416/keryx/keryx-1.0
Reviewer Review Type Date Requested Status
Senthil Kumar_Webrsk (community) Approve
Keryx Admins Pending
Review via email: mp+34770@code.staging.launchpad.net

This proposal supersedes a proposal from 2010-09-07.

Description of the change

I'm trying this merge thing again. So here are the changes:

 * A little modularization.
 * No longer requiring a primary sources list to create a profile.
 * Changed several references to Projects to Profiles.
 * i686 machines are now saved as APT-friendly i386.

To post a comment you must log in.
Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote : Posted in a previous version of this proposal

Looks good and modularization are getting better.

Line No:380. Typo : profiless->profiles

+ self.config.set("profiless", self._get("profiles_filechooserbutton").get_current_folder())

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote : Posted in a previous version of this proposal

The word "project" or "computer" all are now has to be replaced with "profile" . The user will be adding a new profile to set up the keryx (not a computer or project as per keryx 1.0)!! Am i rite?

Revision history for this message
mac9416 (mac9416) wrote : Posted in a previous version of this proposal

I'll resubmit the merge proposal fixing the typo after we make sure there's nothing else needing changing. Thanks for pointing it out.

Chris and I decided we should completely erase the word "project" because it is confusing, and replace it in most places with "profile". But we even wanted to hide the word "profile" with the even simpler "computer" where possible in the GUI. So the references to "profile" in GUI code should probably be dealt with if possible. I'll save that work for another merge request.

BTW, RSK, are you getting email updates about this proposal? I don't see you in the list of subscribers.

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote : Posted in a previous version of this proposal

> I'll resubmit the merge proposal fixing the typo after we make sure there's
> nothing else needing changing. Thanks for pointing it out.
>
> Chris and I decided we should completely erase the word "project" because it
> is confusing, and replace it in most places with "profile". But we even wanted
> to hide the word "profile" with the even simpler "computer" where possible in
> the GUI. So the references to "profile" in GUI code should probably be dealt
> with if possible. I'll save that work for another merge request.
>
> BTW, RSK, are you getting email updates about this proposal? I don't see you
> in the list of subscribers.

That's great.. I was getting the updates as i'm in the reviewer list , now i'm in subscriber list too :)

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) wrote : Posted in a previous version of this proposal

Code is pretty good to understandable. Chris & Mac +1
Ready for next merge proposal..

Revision history for this message
mac9416 (mac9416) wrote :

OK, here it is again with the typo fixed. Now needs Chris's scrutiny.

Revision history for this message
Senthil Kumar_Webrsk (webrsk-ideas) :
review: Approve
41. By mac9416

Merged some changes by RSK and added some of my own.

42. By mac9416

If downloading index files fails, load anyway.

43. By mac9416

Added code behind Download button.

44. By mac9416

Installed Version text is now updated when a package is selected.

Unmerged revisions

44. By mac9416

Installed Version text is now updated when a package is selected.

43. By mac9416

Added code behind Download button.

42. By mac9416

If downloading index files fails, load anyway.

41. By mac9416

Merged some changes by RSK and added some of my own.

40. By mac9416

Typo.

39. By mac9416

A little modularization.

38. By mac9416

No longer requiring a primary sources list to create a profile.

37. By mac9416

Changed several references to Projects to Profiles.

36. By mac9416

i686 machines are now saved as APT-friendly 1386.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches