Keryx

Merge lp://staging/~mac9416/keryx/keryx-1.0 into lp://staging/~excid3/keryx/keryx-1.0

  1. keryx-1.0
  2. Merge into keryx-1.0
Proposed by mac9416
Status: Merged
Merged at revision: 30
Proposed branch: lp://staging/~mac9416/keryx/keryx-1.0
Merge into: lp://staging/~excid3/keryx/keryx-1.0
Diff against target: 197 lines (+97/-23)
4 files modified
.bzrignore (+6/-0)
bin/keryx (+23/-20)
data/ui/KeryxWindow.ui (+3/-3)
keryx/MessageDialogs.py (+65/-0)
To merge this branch: bzr merge lp://staging/~mac9416/keryx/keryx-1.0
Reviewer Review Type Date Requested Status
Chris Oliver Approve
Review via email: mp+32035@code.staging.launchpad.net

Description of the change

I dropped in a module I wrote for 0.92.5 to make it easier to make Message Dialogs.

To post a comment you must log in.
Revision history for this message
mac9416 (mac9416) wrote :

It's going to take a lot of dialogs for the MessageDialogs module to pay for itself in saved lines of code. Maybe you can think of a good way to make MessageDialogs more concise.

Revision history for this message
Chris Oliver (excid3) wrote :

Already on it.

On Sat, Aug 7, 2010 at 10:44 AM, mac9416 <email address hidden> wrote:

> It's going to take a lot of dialogs for the MessageDialogs module to pay
> for itself in saved lines of code. Maybe you can think of a good way to make
> MessageDialogs more concise.
> --
> https://code.launchpad.net/~mac9416/keryx/keryx-1.0/+merge/32035
> You are requested to review the proposed merge of
> lp:~mac9416/keryx/keryx-1.0 into lp:~excid3/keryx/keryx-1.0.
>

--
Chris Oliver
http://excid3.com

Revision history for this message
Chris Oliver (excid3) wrote :

Refactored in commit after merge.

review: Approve
lp://staging/~mac9416/keryx/keryx-1.0 updated
29. By Chris Oliver

Added todo

30. By Chris Oliver

merge lp:~mac9416/keryx/keryx-1.0

Revision history for this message
mac9416 (mac9416) wrote :

You're a good man. Chuck that diff at me when you're done. I'd like to see what you do.

Revision history for this message
Chris Oliver (excid3) wrote :

Done dealio. Check out revision 31 for the sweet update. Might give you some nifty ideas for shortening code.

Revision history for this message
Chris Oliver (excid3) wrote :

Also I've been pushing to both lp:~excid3/keryx/keryx-1.0 AND lp:keryx/unstable so it's available in both. Just merge request to unstable now instead. It's best not to have our main branch a personal one.

Revision history for this message
Chris Oliver (excid3) wrote :

Another note, this isn't thoroughly tested. May be typos. Could you test it if you get a chance?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches