Code review comment for lp://staging/~mabac/linaro-image-tools/scripts-hooks

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

On Wed, Jan 25, 2012 at 6:35 AM, Mattias Backman
<email address hidden> wrote:
>> Tested with 2 simple scripts and it worked well.
>>
>> A few comments:
>> 1. At the preinstall script there's no way to access the hwpack content,
>> because it wasn't yet extracted. This may be useful for people that want to
>> read from hwpack packages or even customize in some way.
>
> Would you like the pre-hooks to be run in linaro-hwpack-install instead? That way the script can be run for every hwpack after unpacking it, meaning the pre-hook is run once per hwpack. If you mean we should unpack all the hwpacks and then run the pre-hook once it will require some more work but it is possible of course.

Can you flash the image using more than one hwpack? I thought it'd use
just one hwpack :-)

Guess to simplify things having the pre-hook the way you implemented
should be fine for now.

« Back to merge proposal