Code review comment for lp://staging/~mabac/linaro-image-tools/scripts-hooks

Revision history for this message
Mattias Backman (mabac) wrote :

> Tested with 2 simple scripts and it worked well.
>
> A few comments:
> 1. At the preinstall script there's no way to access the hwpack content,
> because it wasn't yet extracted. This may be useful for people that want to
> read from hwpack packages or even customize in some way.

Would you like the pre-hooks to be run in linaro-hwpack-install instead? That way the script can be run for every hwpack after unpacking it, meaning the pre-hook is run once per hwpack. If you mean we should unpack all the hwpacks and then run the pre-hook once it will require some more work but it is possible of course.

> 2. Would be useful if we could also copy both scripts at the rootfs, as it
> might help debugging any issues in the future.
> 3. Would also be useful if we could stamp that the image was customized by a
> script, like by adding a message via /etc/update-motd.d, so it'd show that
> info to the user.

« Back to merge proposal