Merge lp://staging/~mabac/launchpad-work-items-tracker/move-card-healh-check into lp://staging/~linaro-automation/launchpad-work-items-tracker/linaro

Proposed by Mattias Backman
Status: Merged
Merged at revision: 312
Proposed branch: lp://staging/~mabac/launchpad-work-items-tracker/move-card-healh-check
Merge into: lp://staging/~linaro-automation/launchpad-work-items-tracker/linaro
Prerequisite: lp://staging/~mabac/launchpad-work-items-tracker/handle-kanbantool-whitespace
Diff against target: 45 lines (+13/-11)
1 file modified
templates/roadmap_card.html (+13/-11)
To merge this branch: bzr merge lp://staging/~mabac/launchpad-work-items-tracker/move-card-healh-check
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Christian Reis user experience Pending
Review via email: mp+85102@code.staging.launchpad.net

Description of the change

Hi,

This branch moves the roadmap card health check to the top right as requested by Kiko.

Thanks,

Mattias

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

 review approve

On Fri, 2011-12-09 at 10:44 +0000, Mattias Backman wrote:
[...]
> === modified file 'templates/roadmap_card.html'
> --- templates/roadmap_card.html 2011-11-30 20:38:49 +0000
> +++ templates/roadmap_card.html 2011-12-09 10:43:21 +0000
> @@ -11,6 +11,18 @@
> </%def>
>
> <h1>${title()}</h1>
> +<div style="float: right">
> +<h3>Health check</h3>
> +
> +<table>${'<tr colspan="2"><td><font color="#FF0000"><b>Needs attention!</b></font></td></tr>' if not card.is_healthy else ''}
> + % for result in health_checks:
> + <tr ${'bgcolor="#FFAAAA"' if result['result'] == 'Not OK' else 'bgcolor="#FFFFFF"'}>
> + <td>${result['name']}</td>
> + <td>${result['result']}</td>
> +</tr>
> +% endfor

The indentation of the two lines above is off by 2 levels and 1 level
respectively. Care to fix it? :)

> +</table>
> +</div>

review: Approve
312. By Mattias Backman

Fix indentation in card html template.

Revision history for this message
Mattias Backman (mabac) wrote :

> review approve
>
> On Fri, 2011-12-09 at 10:44 +0000, Mattias Backman wrote:
> [...]
> > === modified file 'templates/roadmap_card.html'
> > --- templates/roadmap_card.html 2011-11-30 20:38:49 +0000
> > +++ templates/roadmap_card.html 2011-12-09 10:43:21 +0000
> > @@ -11,6 +11,18 @@
> > </%def>
> >
> > <h1>${title()}</h1>
> > +<div style="float: right">
> > +<h3>Health check</h3>
> > +
> > +<table>${'<tr colspan="2"><td><font color="#FF0000"><b>Needs
> attention!</b></font></td></tr>' if not card.is_healthy else ''}
> > + % for result in health_checks:
> > + <tr ${'bgcolor="#FFAAAA"' if result['result'] == 'Not OK' else
> 'bgcolor="#FFFFFF"'}>
> > + <td>${result['name']}</td>
> > + <td>${result['result']}</td>
> > +</tr>
> > +% endfor
>
> The indentation of the two lines above is off by 2 levels and 1 level
> respectively. Care to fix it? :)

Absolutely, thanks for catching that too!

>
> > +</table>
> > +</div>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches