Merge lp://staging/~m982/unity-js-scopes/add-activation-response-update-preview-support into lp://staging/unity-js-scopes
Proposed by
Michael Weimann
| Status: | Merged |
|---|---|
| Approved by: | Alexandre Abreu |
| Approved revision: | 133 |
| Merge reported by: | Alexandre Abreu |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~m982/unity-js-scopes/add-activation-response-update-preview-support |
| Merge into: | lp://staging/unity-js-scopes |
| Diff against target: |
162 lines (+78/-10) 3 files modified
examples/soundcloud/soundcloud.js (+61/-9) src/bindings/src/activation-response.cc (+16/-0) src/bindings/src/activation-response.h (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~m982/unity-js-scopes/add-activation-response-update-preview-support |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandre Abreu (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Description of the change
Adds support for ActivationResponse with the status UpdatePreview. To detect an UpdatePreview the ActivationResponse constructor tests for an Array argument. If it's an Array it maps it to a real ActivationResponse with a PreviewWidgetList.
How to test: Run the soundcloud example scope. You'll find an "Update" action on the preview. Sadly I didn't find unit tests to extend to cover this.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Good code & feature update ! Thank you, +1