Merge lp://staging/~lutostag/charms/trusty/apache2/python-openssl-dep into lp://staging/charms/trusty/apache2

Proposed by Greg Lutostanski
Status: Needs review
Proposed branch: lp://staging/~lutostag/charms/trusty/apache2/python-openssl-dep
Merge into: lp://staging/charms/trusty/apache2
Diff against target: 14 lines (+2/-2)
1 file modified
hooks/install (+2/-2)
To merge this branch: bzr merge lp://staging/~lutostag/charms/trusty/apache2/python-openssl-dep
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+307763@code.staging.launchpad.net

Description of the change

On xenial the dep python-openssl is not installed by default.

This is used when you use set ssl_cert=SELFSIGNED

Traceback encountered:
2016-10-05 20:17:23 INFO reverseproxy-relation-joined Traceback (most recent call last):
2016-10-05 20:17:23 INFO reverseproxy-relation-joined File "/var/lib/juju/agents/unit-ci-oil-apache2-0/charm/hooks/reverseproxy-relation-joined", line 1088, in <module>
2016-10-05 20:17:23 INFO reverseproxy-relation-joined main(hook_name)
2016-10-05 20:17:23 INFO reverseproxy-relation-joined File "/var/lib/juju/agents/unit-ci-oil-apache2-0/charm/hooks/reverseproxy-relation-joined", line 1053, in main
2016-10-05 20:17:23 INFO reverseproxy-relation-joined config_changed()
2016-10-05 20:17:23 INFO reverseproxy-relation-joined File "/var/lib/juju/agents/unit-ci-oil-apache2-0/charm/hooks/reverseproxy-relation-joined", line 666, in config_changed
2016-10-05 20:17:23 INFO reverseproxy-relation-joined if is_selfsigned_cert_stale(config_data, cert_file, key_file):
2016-10-05 20:17:23 INFO reverseproxy-relation-joined File "/var/lib/juju/agents/unit-ci-oil-apache2-0/charm/hooks/reverseproxy-relation-joined", line 217, in is_selfsigned_cert_stale
2016-10-05 20:17:23 INFO reverseproxy-relation-joined from OpenSSL import crypto
2016-10-05 20:17:23 INFO reverseproxy-relation-joined ImportError: No module named OpenSSL
2016-10-05 20:17:23 ERROR juju.worker.uniter.operation runhook.go:107 hook "reverseproxy-relation-joined" failed: exit status 1

other workaround would be to add 'python-openssl' to extra_packages, but as documented in config.yaml as is, it should probably be a hard dependency.

To post a comment you must log in.

Unmerged revisions

73. By Greg Lutostanski

also install python-openssl dep

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: