Merge lp://staging/~lutostag/charms/trusty/apache2/multiple-extra-packages into lp://staging/charms/trusty/apache2
Proposed by
Greg Lutostanski
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~lutostag/charms/trusty/apache2/multiple-extra-packages |
| Merge into: | lp://staging/charms/trusty/apache2 |
| Diff against target: |
10 lines (+1/-1) 1 file modified
hooks/hooks.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~lutostag/charms/trusty/apache2/multiple-extra-packages |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
Allow installing more than just 1 extra_package (as the name implies extra_packages).
if you set extra_packages=
neither will get installed with the following error:
2016-10-05 20:36:17 INFO reverseproxy-
This is because with the subprocess.call it does not automatically split space delimited args and passes it as one commandline arg to apt-get which thinks it is just one package name.
To post a comment you must log in.
Unmerged revisions
- 73. By Greg Lutostanski
-
allow installing multiple extra_packages
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
