Juju Charms Collection
apache2 package

Merge lp://staging/~lutostag/charms/trusty/apache2/fix-extra-package-hold into lp://staging/charms/trusty/apache2

  1. Trusty Tahr (14.04)
  2. fix-extra-package-hold
  3. Merge into trunk
Proposed by Greg Lutostanski
Status: Merged
Merged at revision: 71
Proposed branch: lp://staging/~lutostag/charms/trusty/apache2/fix-extra-package-hold
Merge into: lp://staging/charms/trusty/apache2
Diff against target: 13 lines (+2/-1)
1 file modified
hooks/hooks.py (+2/-1)
To merge this branch: bzr merge lp://staging/~lutostag/charms/trusty/apache2/fix-extra-package-hold
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
Konstantinos Tsakalozos (community) Approve
Review via email: mp+287224@code.staging.launchpad.net

Description of the change

There was a bug where the extra packages installed are passed as a string rather than list of packages to ensure_package_status. This fixes that (not fatal, just a warning, but still annoying).

As seen from my unit log which led me in this direction...:
juju set ci-oil-apache2 extra_packages=python-apache-openid

unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: p
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: y
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: t
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: h
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: o
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: warning: package not in database at line 1: n
unit-ci-oil-apache2-0[10000]: 2016-02-25 20:31:07 INFO unit.ci-oil-apache2/0.config-changed logger.go:40 dpkg: error: illegal package name at line 1: illegal package name in specifier '-': must start with an alpha
numeric character

To post a comment you must log in.
Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Thank you for the fix, we appreciate your time.

review: Approve
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

+1, merged. Thanks for the fix Greg, and for the review Kostas.

An updated apache2 charm should hit the store in about an hour.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: