Merge into trunk : preventScrollThruShellElements : Code : Unity 8

Reviewer	Review Type	Date Requested	Status
Unity8 CI Bot	continuous-integration		Approve on 2016-06-19
Daniel d'Andrada (community)		2016-06-10	Approve on 2016-06-15
Review via email: mp+297079@code.staging.launchpad.net

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-10:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1464/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-13:

#

Works fine.

Would be great if you could update copyright headers of:
qml/Launcher/LauncherPanel.qml
qml/Panel/IndicatorsMenu.qml
tests/qmltests/Launcher/tst_Launcher.qml
tests/qmltests/Panel/tst_IndicatorsMenu.qml

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-13:

#

Both in tst_IndicatorsMenu.qml and tst_Launcher.qml you should reset wheelSignalSpy in the cleanup() function.

If some other test starts using wheelSignalSpy (as it's an asset free for any test function to use) it would leave it in a dirty state for the next.

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-14:

#

Please also include a fix for that:
https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1536268/comments/1

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-15

2445. By Lukáš Tinkl on 2016-06-15: update (c)
2446. By Lukáš Tinkl on 2016-06-15: clear signal spies in cleanup()

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1477/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1478/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-15

2447. By Lukáš Tinkl on 2016-06-15: prevent the wheel also from going thru the desktop spread

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-06-15:

#

> Works fine.
>
> Would be great if you could update copyright headers of:
> qml/Launcher/LauncherPanel.qml
> qml/Panel/IndicatorsMenu.qml
> tests/qmltests/Launcher/tst_Launcher.qml
> tests/qmltests/Panel/tst_IndicatorsMenu.qml

Copyright years updated

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-06-15:

#

> Both in tst_IndicatorsMenu.qml and tst_Launcher.qml you should reset
> wheelSignalSpy in the cleanup() function.
>
> If some other test starts using wheelSignalSpy (as it's an asset free for any
> test function to use) it would leave it in a dirty state for the next.

OK, done

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-06-15:

#

> Please also include a fix for that:
> https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1536268/comments/1

Fixed (with a test as well)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1479/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-15

2448. By Lukáš Tinkl on 2016-06-15: cleanup unneded stuff with the MouseArea

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-15:

#

Just noticed that right mouse button clicks go through the spread as well. Man, so many holes in those mouse event eaters...

I would vote for creating a MouseEater component and using it throughout unity8. Would save us for making the same mistakes over and over again.

The MouseEater must eat all buttons, wheel events and hover events.

I know that your bug and MP is just about scroll wheel events, but it would be a good opportunity to plug all holes once and for all. So I'm coll if we do this in a later MP.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1481/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-15

2449. By Lukáš Tinkl on 2016-06-15: also prevent non-left mouse clicks

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-15:

#

Well, since you decided to get started on right-click leakage here as well then please plug that hole in the indicators panel. It does leak right-clicks.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1482/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-15

2450. By Lukáš Tinkl on 2016-06-15: plug even more holes

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-06-15:

#

Alright, hopefully all the shell mouse event leaks plugged

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-15:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1483/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-06-15:

#

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass? If not, please explain why.
No due to missing dependencies from the prerequisite. Modified tests passed locally though.

review: Approve

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-06-19:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1527/rebuild

PASSED: Continuous integration, rev:2450
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1527/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2030
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1040
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1040
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1040
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2058
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1974
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1974
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1974
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1965/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1965
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1965/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1527/rebuild

review: Approve (continuous-integration)

lp://staging/~lukas-kde/unity8/preventScrollThruShellElements updated on 2016-06-20

2451. By Lukáš Tinkl on 2016-06-20: merge trunk

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2016-06-20:

#

> Just noticed that right mouse button clicks go through the spread as well.
> Man, so many holes in those mouse event eaters...
>
> I would vote for creating a MouseEater component and using it throughout
> unity8. Would save us for making the same mistakes over and over again.
>
> The MouseEater must eat all buttons, wheel events and hover events.
>
> I know that your bug and MP is just about scroll wheel events, but it would be
> a good opportunity to plug all holes once and for all. So I'm coll if we do
> this in a later MP.

+1 on this.

Something like:

MouseEater.qml

MouseArea {
  property bool eatsLeftClick: true
  property bool eatsRightClick: true
  property bool eatsScrolling: true

onPressed: if (eatsLeftClick) mouse.accepted = true
onScroll: if (eatsScrolling) scroll.accepted = true
}

Unity 8

Merge lp://staging/~lukas-kde/unity8/preventScrollThruShellElements into lp://staging/unity8

Commit message

Description of the change

Preview Diff

Subscribers