Merge lp://staging/~lukas-kde/unity8/chineseInputOSK into lp://staging/unity8
Proposed by
Lukáš Tinkl
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2442 |
| Merged at revision: | 2477 |
| Proposed branch: | lp://staging/~lukas-kde/unity8/chineseInputOSK |
| Merge into: | lp://staging/unity8 |
| Diff against target: |
61 lines (+20/-6) 2 files modified
qml/Wizard/Pages/10-welcome.qml (+17/-4) tests/mocks/Ubuntu/SystemSettings/LanguagePlugin/MockLanguagePlugin.qml (+3/-2) |
| To merge this branch: | bzr merge lp://staging/~lukas-kde/unity8/chineseInputOSK |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Michael Terry | Approve | ||
| Unity Team | Pending | ||
|
Review via email:
|
|||
Commit message
Select correct Chinese input method for OSK in the wizard
Description of the change
Select correct Chinese input method for OSK in the wizard
Fixes lp:1588633
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. Watched Lukas play with it on his phone.
Minor nit in mock that Hongkong should be "Hong Kong", but I'm not blocking on that.