Merge lp://staging/~lukas-kde/unity8/add-autotest-lp1680018 into lp://staging/unity8

Proposed by Lukáš Tinkl
Status: Approved
Approved by: Albert Astals Cid
Approved revision: 2919
Proposed branch: lp://staging/~lukas-kde/unity8/add-autotest-lp1680018
Merge into: lp://staging/unity8
Prerequisite: lp://staging/~lukas-kde/unity8/fix-window-title-vs-menu
Diff against target: 66 lines (+22/-5)
2 files modified
qml/Stage/WindowDecoration.qml (+1/-0)
tests/qmltests/tst_Shell.qml (+21/-5)
To merge this branch: bzr merge lp://staging/~lukas-kde/unity8/add-autotest-lp1680018
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+321974@code.staging.launchpad.net

Commit message

Add autotest for missing window control buttons after a maximized window exits spread

Description of the change

Add autotest for missing window control buttons after a maximized window exits spread

Fixes lp:1680018

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

I think you should add two testcases more in test_selectFromSpreadWithMouse_data so that we also run the test without the requestMaximize like we did before, what do you think?

review: Needs Information
2917. By Lukáš Tinkl

add a maximized variant

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> I think you should add two testcases more in
> test_selectFromSpreadWithMouse_data so that we also run the test without the
> requestMaximize like we did before, what do you think?

Done

2918. By Lukáš Tinkl

let the restore() call only be in the if block

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2916
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3687/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4896
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/3002
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/3002
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4924
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4732/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4732/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4732/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4732/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4732/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4732
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4732/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3687/rebuild

review: Approve (continuous-integration)
2919. By Lukáš Tinkl

fixup the data mess

Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2918
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3690/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4900
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4928
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4736/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4736/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4736/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4736/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4736/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4736
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4736/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3690/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2919. By Lukáš Tinkl

fixup the data mess

2918. By Lukáš Tinkl

let the restore() call only be in the if block

2917. By Lukáš Tinkl

add a maximized variant

2916. By Lukáš Tinkl

add regression test for lp:1680018

2915. By Lukáš Tinkl

merge lp:~lukas-kde/unity8/fix-window-title-vs-menu

2914. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches