Merge lp://staging/~lukas-kde/ubuntu-system-settings/language-list into lp://staging/ubuntu-system-settings

Proposed by Lukáš Tinkl
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1746
Merged at revision: 1747
Proposed branch: lp://staging/~lukas-kde/ubuntu-system-settings/language-list
Merge into: lp://staging/ubuntu-system-settings
Prerequisite: lp://staging/~lukas-kde/ubuntu-system-settings/new-menu-components
Diff against target: 154 lines (+26/-67)
2 files modified
plugins/language/language-plugin.cpp (+25/-64)
plugins/language/language-plugin.h (+1/-3)
To merge this branch: bzr merge lp://staging/~lukas-kde/ubuntu-system-settings/language-list
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+311032@code.staging.launchpad.net

Commit message

Language pack based language setup

Description of the change

Do the lookup of languages based on installed language packs. Do not rely on parsing "locale -a" or "language-tools/language2locale" output as that won't work in snappy world due to hardcoded paths.

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

See inline comment

review: Needs Information
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> See inline comment

Replied inline as well

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Oops. try again with inline comment

1746. By Lukáš Tinkl

merge trunk

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Works well now, thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches