Ubuntu Settings Components

Merge lp://staging/~lukas-kde/ubuntu-settings-components/rtlFixes into lp://staging/ubuntu-settings-components

  1. rtlFixes
  2. Merge into trunk
Proposed by Lukáš Tinkl
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 170
Merged at revision: 173
Proposed branch: lp://staging/~lukas-kde/ubuntu-settings-components/rtlFixes
Merge into: lp://staging/ubuntu-settings-components
Prerequisite: lp://staging/~3v1n0/ubuntu-settings-components/new-calendar-design
Diff against target: 103 lines (+18/-3)
7 files modified
plugins/Ubuntu/Settings/Components/Calendar.qml (+1/-1)
plugins/Ubuntu/Settings/Components/MessageHeader.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/BaseLayoutMenu.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+1/-1)
plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/SliderMenu.qml (+4/-1)
plugins/Ubuntu/Settings/Menus/TransferMenu.qml (+3/-0)
To merge this branch: bzr merge lp://staging/~lukas-kde/ubuntu-settings-components/rtlFixes
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+310180@code.staging.launchpad.net

Commit message

Indicator components fixes for right-to-left languages (RTL)

Apart from the physical prereq, this branch needs:
- u8: https://code.launchpad.net/~lukas-kde/unity8/loadQtCatalog/+merge/309414 (to fix enabling RTL on startup)
- uitk: https://code.launchpad.net/~lukas-kde/ubuntu-ui-toolkit/sliderStyleRTL/+merge/309461 (to fix the progress of any slider component)

Description of the change

Indicator components fixes for right-to-left languages (RTL)

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:170
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/112/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3255
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3283
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3137/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/112/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, a part from that unrelated change which is quite conflicts prone :-)

review: Approve
lp://staging/~lukas-kde/ubuntu-settings-components/rtlFixes updated
171. By Lukáš Tinkl

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: