Session Menu

Merge lp://staging/~lukas-kde/indicator-session/desktopModeSwitch into lp://staging/indicator-session/15.10

  1. desktopModeSwitch
  2. Merge into trunk.15.10
Proposed by Lukáš Tinkl
Status: Merged
Approved by: Michael Zanetti
Approved revision: 476
Merged at revision: 468
Proposed branch: lp://staging/~lukas-kde/indicator-session/desktopModeSwitch
Merge into: lp://staging/indicator-session/15.10
Diff against target: 211 lines (+95/-7)
2 files modified
src/backend-dbus/actions.c (+4/-1)
src/service.c (+91/-6)
To merge this branch: bzr merge lp://staging/~lukas-kde/indicator-session/desktopModeSwitch
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Antti Kaijanmäki (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+288413@code.staging.launchpad.net

Commit message

Add a "Desktop mode" switch for Unity 8

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:469
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/154/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/154/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:470
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/155/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/155/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:471
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/156/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/7
        deb: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/7/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/156/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:472
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/157/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/indicator-session-wily-armhf-ci/8/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/157/rebuild

review: Approve (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM!

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

acking the changes after Antti approved

review: Approve
lp://staging/~lukas-kde/indicator-session/desktopModeSwitch updated
477. By Michael Terry

Only use unity8 schema if it's installed to avoid hard dependency on unity8-schemas

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches