Code review comment for ~lucaskanashiro/ubuntu/+source/pacemaker:merge-version-2.0.5

Revision history for this message
Bryce Harrington (bryce) wrote :

* Changelog:
  - [√] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [-] debian changes look safe

* Old Delta:
  - [√] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [√] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

Looks good. I didn't doublecheck each of the commits as landed upstream since there were quite a few. I did verify installation/upgradability. Autopkgtest in a local lxc container passes fine for me:

triage-hirsute+21.04:~/pkg/Phpunit/phpunit-unblock/composer-2.0.8$ apt-cache policy pacemaker
pacemaker:
  Installed: 2.0.5-2ubuntu1~ppa2
  Candidate: 2.0.5-2ubuntu1~ppa2
  Version table:
 *** 2.0.5-2ubuntu1~ppa2 500
        500 http://ppa.launchpad.net/lucaskanashiro/ha-stack/ubuntu hirsute/main amd64 Packages
        100 /var/lib/dpkg/status
     2.0.4-2ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 Packages
     2.0.4-2ubuntu3.1 500
        500 http://archive.ubuntu.com/ubuntu hirsute/main amd64 Packages
triage-hirsute+21.04:~/pkg/Phpunit/phpunit-unblock/composer-2.0.8$ sudo autopkgtest pacemaker -- null
autopkgtest [02:50:46]: @@@@@@@@@@@@@@@@@@@@ summary
pacemaker SKIP exit status 77 and marked as skippable
pkg-config PASS (superficial)

A minor changelog verbage suggestion inlined below.

review: Approve

« Back to merge proposal