Merge ~lucaskanashiro/+git/r-cran-htmltools:fix-dep8 into ~lucaskanashiro/+git/r-cran-htmltools:master

Proposed by Lucas Kanashiro
Status: Approved
Approved by: Lucas Kanashiro
Approved revision: 7afe60e3cfb0835f5953f4736e04beb6b505349e
Proposed branch: ~lucaskanashiro/+git/r-cran-htmltools:fix-dep8
Merge into: ~lucaskanashiro/+git/r-cran-htmltools:master
Diff against target: 79 lines (+49/-1)
4 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/0001-Fix-path-to-txt-files-in-DEP-8-tests.patch (+40/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Lucas Kanashiro Pending
Review via email: mp+390496@code.staging.launchpad.net

Description of the change

Fix DEP-8 test failure blocking its migration. The path to some test artifacts is not properly set when executed with autopkgtest, a patch was added to handle this.

The patch as also forwarded to Debian here:

https://bugs.debian.org/969288

autopkgtest is happy now:

autopkgtest [16:07:19]: @@@@@@@@@@@@@@@@@@@@ summary
run-unit-test PASS
pkg-r-autopkgtest PASS

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks like the check for AUTOPKGTEST_TMP is simply to determine that the test is being executed by autopkgtest. I don't know of a better best practice, and this is documented in the autopkgtest README so seems like a good approach.

The patch description is a bit incomplete, I might suggest a slight tweak to clarify:

 +The test_path() does not work as expected when the tests are not run
 +from the upstream source tree. When running under Autopkgtest, load
 + the .txt files relative to the current directory, instead of using
 +test_path().

Rest of the packaging LGTM, +1.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review and your suggestion Bryce! I applied the changes and I am going to upload it.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

$ dput ubuntu ../r-cran-htmltools_0.5.0-1ubuntu1_source.changes
Checking signature on .changes
gpg: ../r-cran-htmltools_0.5.0-1ubuntu1_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../r-cran-htmltools_0.5.0-1ubuntu1.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading r-cran-htmltools_0.5.0-1ubuntu1.dsc: done.
  Uploading r-cran-htmltools_0.5.0-1ubuntu1.debian.tar.xz: done.
  Uploading r-cran-htmltools_0.5.0-1ubuntu1_source.changes: done.
Successfully uploaded packages.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: