Merge ~lucaskanashiro/+git/r-cran-htmltools:fix-dep8 into ~lucaskanashiro/+git/r-cran-htmltools:master
Proposed by
Lucas Kanashiro
Status: | Approved |
---|---|
Approved by: | Lucas Kanashiro |
Approved revision: | 7afe60e3cfb0835f5953f4736e04beb6b505349e |
Proposed branch: | ~lucaskanashiro/+git/r-cran-htmltools:fix-dep8 |
Merge into: | ~lucaskanashiro/+git/r-cran-htmltools:master |
Diff against target: |
79 lines (+49/-1) 4 files modified
debian/changelog (+6/-0) debian/control (+2/-1) debian/patches/0001-Fix-path-to-txt-files-in-DEP-8-tests.patch (+40/-0) debian/patches/series (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Lucas Kanashiro | Pending | ||
Review via email: mp+390496@code.staging.launchpad.net |
Description of the change
Fix DEP-8 test failure blocking its migration. The path to some test artifacts is not properly set when executed with autopkgtest, a patch was added to handle this.
The patch as also forwarded to Debian here:
https:/
autopkgtest is happy now:
autopkgtest [16:07:19]: @@@@@@@
run-unit-test PASS
pkg-r-autopkgtest PASS
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Looks like the check for AUTOPKGTEST_TMP is simply to determine that the test is being executed by autopkgtest. I don't know of a better best practice, and this is documented in the autopkgtest README so seems like a good approach.
The patch description is a bit incomplete, I might suggest a slight tweak to clarify:
+The test_path() does not work as expected when the tests are not run
+from the upstream source tree. When running under Autopkgtest, load
+ the .txt files relative to the current directory, instead of using
+test_path().
Rest of the packaging LGTM, +1.